fixup! [New] Symmetric useState hook variable names

Author: duncanbeevers

lib/rules/hook-use-state.js

@@ -32,6 +32,13 @@ module.exports = {
 
   create: Components.detect((context, components) => ({
     CallExpression(node) {
+      const isImmediateReturn = node.parent
+        && node.parent.type === 'ReturnStatement';
+
+      if (isImmediateReturn) {
+        return;
+      }
+
       const defaultReactImport = components.getDefaultReactImport();
       const namedReactImports = components.getNamedReactImports();
       const defaultReactImportName = defaultReactImport
@@ -64,15 +71,9 @@ module.exports = {
         return;
       }
 
-      const isImmediateReturn = node.parent && node.parent.type === 'ReturnStatement';
-      if (isImmediateReturn) {
-        return;
-      }
-
-      const isDestructuringDeclarator = (
-        node.parent.type === 'VariableDeclarator'
-          && node.parent.id.type === 'ArrayPattern'
-      );
+      const isDestructuringDeclarator = node.parent
+        && node.parent.type === 'VariableDeclarator'
+        && node.parent.id.type === 'ArrayPattern';
 
       if (!isDestructuringDeclarator) {
         report(
@@ -100,12 +101,12 @@ module.exports = {
         `set${valueVariableName.charAt(0).toUpperCase()}${valueVariableName.slice(1)}`
       ) : undefined;
 
-      if (
-        !valueVariable
-          || !setterVariable
-          || setterVariableName !== expectedSetterVariableName
-          || variableNodes.length !== 2
-      ) {
+      const isSymmetricGetterSetterPair = valueVariable
+        && setterVariable
+        && setterVariableName === expectedSetterVariableName
+        && variableNodes.length === 2;
+
+      if (!isSymmetricGetterSetterPair) {
         report(
           context,
           messages.useStateErrorMessage,