Skip to content

Commit 9b595b9

Browse files
committed
resolve previous commit
1 parent 0bf8373 commit 9b595b9

File tree

2 files changed

+10
-1
lines changed

2 files changed

+10
-1
lines changed

lib/rules/jsx-no-target-blank.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@ function hasSecureRel(node, allowReferrer, warnOnSpreadAttributes, spreadAttribu
103103

104104
const relAttribute = node.attributes[relIndex];
105105
const value = getStringFromValue(relAttribute.value);
106-
return [].concat(value).filter(Boolean).some((item) => {
106+
return [].concat(value).filter(Boolean).every((item) => {
107107
const tags = typeof item === 'string' && item.toLowerCase().split(' ');
108108
const noreferrer = tags && tags.indexOf('noreferrer') >= 0;
109109
const noopener = tags && tags.indexOf('noopener') >= 0;

tests/lib/rules/jsx-no-target-blank.js

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -390,5 +390,14 @@ ruleTester.run('jsx-no-target-blank', rule, {
390390
code: '<a href={href} target="_blank" rel={isExternal ? 3 : "noopener noreferrer"} />',
391391
errors: defaultErrors,
392392
},
393+
{
394+
code: '<a href={href} target="_blank" rel={isExternal ? "noopener noreferrer" : "3"} />',
395+
errors: defaultErrors,
396+
},
397+
{
398+
code: '<a href={href} target="_blank" rel={isExternal ? "noopener" : "2"} />',
399+
options: [{ allowReferrer: true }],
400+
errors: allowReferrerErrors,
401+
},
393402
]),
394403
});

0 commit comments

Comments
 (0)