fixed array type, noopener condtion test failing

Author: V2dha

lib/rules/jsx-no-target-blank.js

@@ -81,11 +81,11 @@ function attributeValuePossiblyRel(value) {
 function getStringFromValue(value) {
   if (value) {
     if (value.type === 'Literal') {
-      return [value.value];
+      return value.value;
     }
     if (value.type === 'JSXExpressionContainer') {
       if (value.expression.type === 'TemplateLiteral') {
-        return [value.expression.quasis[0].value.cooked];
+        return value.expression.quasis[0].value.cooked;
       }
       const expr = value.expression;
       if (expr.type === 'ConditionalExpression') {
@@ -96,10 +96,10 @@ function getStringFromValue(value) {
           return [expr.consequent.value, expr.alternate.value];
         }
       }
-      return [value.expression && value.expression.value];
+      return value.expression && value.expression.value;
     }
   }
-  return [null];
+  return null;
 }
 
 function hasSecureRel(node, allowReferrer, warnOnSpreadAttributes, spreadAttributeIndex) {
@@ -110,14 +110,23 @@ function hasSecureRel(node, allowReferrer, warnOnSpreadAttributes, spreadAttribu
 
   const relAttribute = node.attributes[relIndex];
   const value = getStringFromValue(relAttribute.value);
-  for (let index = 0; index < value.length; index++) {
-    const tags = value[index] && typeof value[index] === 'string' && value[index].toLowerCase().split(' ');
-    const noreferrer = tags && tags.indexOf('noreferrer') >= 0;
-    if (noreferrer) {
-      return true;
+  if (Array.isArray(value)) {
+    for (let index = 0; index < value.length; index++) {
+      const tags = value[index] && typeof value[index] === 'string' && value[index].toLowerCase().split(' ');
+      const noreferrer = tags && tags.indexOf('noreferrer') >= 0;
+      const noopener = tags && tags.indexOf('noopener') >= 0;
+      if (!noreferrer) {
+        return allowReferrer && noopener;
+      }
     }
-    return allowReferrer && tags && tags.indexOf('noopener') >= 0;
+    return true;
+  }
+  const tags = value && typeof value === 'string' && value.toLowerCase().split(' ');
+  const noreferrer = tags && tags.indexOf('noreferrer') >= 0;
+  if (noreferrer) {
+    return true;
   }
+  return allowReferrer && tags && tags.indexOf('noopener') >= 0;
 }
 
 const messages = {

tests/lib/rules/jsx-no-target-blank.js

@@ -148,7 +148,11 @@ ruleTester.run('jsx-no-target-blank', rule, {
       code: '<a href={href} target={isExternal ? undefined : "_blank"} rel={isExternal ? "noreferrer" : "noopener noreferrer"} />',
     },
     {
-      code: '<a href={href} target="_blank" rel={isExternal ? "noreferrer" : "noopener noreferrer"} />',
+      code: '<a href={href} target={isExternal ? undefined : "_blank"} rel={isExternal ? "noreferrer noopener" : "noreferrer"} />',
+    },
+    {
+      code: '<a href={href} target="_blank" rel={isExternal ? "noreferrer" : "noopener"} />',
+      options: [{ allowReferrer: true }],
     },
   ]),
   invalid: parsers.all([
@@ -366,25 +370,33 @@ ruleTester.run('jsx-no-target-blank', rule, {
       errors: defaultErrors,
     },
     {
-      code: '<a href={href} target="_blank" rel={isExternal ? "noopener" : "undefined"} />',
+      code: '<a href={href} target="_blank" rel={isExternal ? "noopener" : undefined} />',
       errors: defaultErrors,
     },
     {
       code: '<a href={href} target="_blank" rel={isExternal ? "undefined" : "noopener"} />',
       errors: defaultErrors,
     },
-    // {
-    //   code: '<a href={href} target={isExternal ? "_blank" : undefined} rel={isExternal ? "noopener noreferrer" : undefined} />',
-    // },
-    // {
-    //   code: '<a href={href} target={isExternal ? "_blank" : undefined} rel={isExternal ? undefined : "noopener noreferrer"} />',
-    // },
-    // {
-    //   code: '<a href={href} target="_blank" rel={isExternal ? 3 : "noopener noreferrer"} />',
-    // },
+    {
+      code: '<a href={href} target={isExternal ? "_blank" : undefined} rel={isExternal ? "noopener noreferrer" : undefined} />',
+      errors: defaultErrors,
+    },
+    {
+      code: '<a href={href} target={isExternal ? "_blank" : undefined} rel={isExternal ? undefined : "noopener noreferrer"} />',
+      errors: defaultErrors,
+    },
+    {
+      code: '<a href={href} target="_blank" rel={isExternal ? 3 : "noopener noreferrer"} />',
+      errors: defaultErrors,
+    },
     {
       code: '<a href={href} target="_blank" rel={isExternal ? "noopener noreferrer" : "3"} />',
       errors: defaultErrors,
     },
+    // {
+    //   code: '<a href={href} target="_blank" rel={isExternal ? "noopener" : "2"} />',
+    //   options: [{ allowReferrer: true }],
+    //   errors: defaultErrors,
+    // },
   ]),
 });