[Refactor] improve performance by avoiding unnecessary Components.detect

Author: chiawendt

CHANGELOG.md

@@ -24,7 +24,9 @@ This change log adheres to standards from [Keep a CHANGELOG](https://keepachange
 * [Refactor] improve performance for detecting class components ([#3267][] @golopot)
 * [Refactor] [`no-deprecated`]: improve performance ([#3271][] @golopot)
 * [Refactor] [`no-did-mount-set-state`], [`no-did-update-set-state`], [`no-will-update-set-state`]: improve performance ([#3272][] @golopot)
+* [Refactor] improve performance by avoiding unnecessary `Components.detect` ([#3273][] @golopot)
 
+[#3273]: https://github.com/jsx-eslint/eslint-plugin-react/pull/3273
 [#3272]: https://github.com/jsx-eslint/eslint-plugin-react/pull/3272
 [#3271]: https://github.com/jsx-eslint/eslint-plugin-react/pull/3271
 [#3267]: https://github.com/jsx-eslint/eslint-plugin-react/pull/3267

lib/rules/display-name.js

@@ -9,6 +9,7 @@ const values = require('object.values');
 
 const Components = require('../util/Components');
 const astUtil = require('../util/ast');
+const componentUtil = require('../util/componentUtil');
 const docsUrl = require('../util/docsUrl');
 const propsUtil = require('../util/props');
 const report = require('../util/report');
@@ -106,7 +107,7 @@ module.exports = {
         astUtil.isFunctionLikeExpression(node)
         && node.parent
         && (node.parent.type === 'VariableDeclarator' || node.parent.type === 'Property' || node.parent.method === true)
-        && (!node.parent.parent || !utils.isES5Component(node.parent.parent))
+        && (!node.parent.parent || !componentUtil.isES5Component(node.parent.parent, context))
       );
 
       if (
@@ -192,7 +193,7 @@ module.exports = {
       },
 
       ObjectExpression(node) {
-        if (!utils.isES5Component(node)) {
+        if (!componentUtil.isES5Component(node, context)) {
           return;
         }
         if (ignoreTranspilerName || !hasTranspilerName(node)) {

lib/rules/jsx-indent.js

@@ -36,7 +36,6 @@ const astUtil = require('../util/ast');
 const docsUrl = require('../util/docsUrl');
 const reportC = require('../util/report');
 const jsxUtil = require('../util/jsx');
-const isCreateElement = require('../util/isCreateElement');
 
 // ------------------------------------------------------------------------------
 // Rule Definition
@@ -428,7 +427,7 @@ module.exports = {
         }
         if (
           !fn
-          || !jsxUtil.isReturningJSX((n) => isCreateElement(n, context), node, context, true)
+          || !jsxUtil.isReturningJSX(node, context, true)
         ) {
           return;
         }

lib/rules/jsx-no-bind.js

@@ -8,7 +8,6 @@
 'use strict';
 
 const propName = require('jsx-ast-utils/propName');
-const Components = require('../util/Components');
 const docsUrl = require('../util/docsUrl');
 const jsxUtil = require('../util/jsx');
 const report = require('../util/report');
@@ -63,7 +62,7 @@ module.exports = {
     }],
   },
 
-  create: Components.detect((context) => {
+  create(context) {
     const configuration = context.options[0] || {};
 
     // Keep track of all the variable names pointing to a bind call,
@@ -198,5 +197,5 @@ module.exports = {
         }
       },
     };
-  }),
+  },
 };

lib/rules/no-access-state-in-setstate.js

@@ -6,7 +6,7 @@
 'use strict';
 
 const docsUrl = require('../util/docsUrl');
-const Components = require('../util/Components');
+const componentUtil = require('../util/componentUtil');
 const report = require('../util/report');
 
 // ------------------------------------------------------------------------------
@@ -29,7 +29,7 @@ module.exports = {
     messages,
   },
 
-  create: Components.detect((context, components, utils) => {
+  create(context) {
     function isSetStateCall(node) {
       return node.type === 'CallExpression'
         && node.callee.property
@@ -48,7 +48,7 @@ module.exports = {
     }
 
     function isClassComponent() {
-      return !!(utils.getParentES6Component() || utils.getParentES5Component());
+      return !!(componentUtil.getParentES6Component(context) || componentUtil.getParentES5Component(context));
     }
 
     // The methods array contains all methods or functions that are using this.state
@@ -183,5 +183,5 @@ module.exports = {
         });
       },
     };
-  }),
+  },
 };

lib/rules/no-arrow-function-lifecycle.js

@@ -9,6 +9,7 @@ const values = require('object.values');
 
 const Components = require('../util/Components');
 const astUtil = require('../util/ast');
+const componentUtil = require('../util/componentUtil');
 const docsUrl = require('../util/docsUrl');
 const lifecycleMethods = require('../util/lifecycleMethods');
 const report = require('../util/report');
@@ -44,7 +45,7 @@ module.exports = {
     fixable: 'code',
   },
 
-  create: Components.detect((context, components, utils) => {
+  create: Components.detect((context, components) => {
     /**
      * @param {Array} properties list of component properties
      */
@@ -57,7 +58,7 @@ module.exports = {
         const propertyName = astUtil.getPropertyName(node);
         const nodeType = node.value.type;
         const isLifecycleMethod = (
-          node.static && !utils.isES5Component(node)
+          node.static && !componentUtil.isES5Component(node, context)
             ? lifecycleMethods.static
             : lifecycleMethods.instance
         ).indexOf(propertyName) > -1;

lib/rules/no-deprecated.js

@@ -8,9 +8,8 @@
 'use strict';
 
 const values = require('object.values');
-
-const Components = require('../util/Components');
 const astUtil = require('../util/ast');
+const componentUtil = require('../util/componentUtil');
 const docsUrl = require('../util/docsUrl');
 const pragmaUtil = require('../util/pragma');
 const testReactVersion = require('../util/version').testReactVersion;
@@ -104,7 +103,7 @@ module.exports = {
     schema: [],
   },
 
-  create: Components.detect((context, components, utils) => {
+  create(context) {
     const pragma = pragmaUtil.getFromContext(context);
     const deprecated = getDeprecated(pragma);
 
@@ -167,7 +166,10 @@ module.exports = {
      * @param {ASTNode} node The AST node being checked.
      */
     function checkLifeCycleMethods(node) {
-      if (utils.isES5Component(node) || utils.isES6Component(node)) {
+      if (
+        componentUtil.isES5Component(node, context)
+     || componentUtil.isES6Component(node, context)
+      ) {
         const methods = getLifeCycleMethods(node);
         methods.forEach((method) => checkDeprecation(node, method.name, method.node));
       }
@@ -221,5 +223,5 @@ module.exports = {
       ClassExpression: checkLifeCycleMethods,
       ObjectExpression: checkLifeCycleMethods,
     };
-  }),
+  },
 };

lib/rules/no-direct-mutation-state.js

@@ -7,6 +7,7 @@
 'use strict';
 
 const Components = require('../util/Components');
+const componentUtil = require('../util/componentUtil');
 const docsUrl = require('../util/docsUrl');
 const report = require('../util/report');
 
@@ -99,7 +100,7 @@ module.exports = {
           return;
         }
         const item = getOuterMemberExpression(node.left);
-        if (utils.isStateMemberExpression(item)) {
+        if (componentUtil.isStateMemberExpression(item)) {
           const mutations = (component && component.mutations) || [];
           mutations.push(node.left.object);
           components.set(node, {
@@ -115,7 +116,7 @@ module.exports = {
           return;
         }
         const item = getOuterMemberExpression(node.argument);
-        if (utils.isStateMemberExpression(item)) {
+        if (componentUtil.isStateMemberExpression(item)) {
           const mutations = (component && component.mutations) || [];
           mutations.push(item);
           components.set(node, {

lib/rules/no-redundant-should-component-update.js

@@ -4,8 +4,8 @@
 
 'use strict';
 
-const Components = require('../util/Components');
 const astUtil = require('../util/ast');
+const componentUtil = require('../util/componentUtil');
 const docsUrl = require('../util/docsUrl');
 const report = require('../util/report');
 
@@ -31,7 +31,7 @@ module.exports = {
     schema: [],
   },
 
-  create: Components.detect((context, components, utils) => {
+  create(context) {
     /**
      * Checks for shouldComponentUpdate property
      * @param {ASTNode} node The AST node being checked.
@@ -65,7 +65,7 @@ module.exports = {
      * @param {ASTNode} node The AST node being checked.
      */
     function checkForViolation(node) {
-      if (utils.isPureComponent(node)) {
+      if (componentUtil.isPureComponent(node, context)) {
         const hasScu = hasShouldComponentUpdate(node);
         if (hasScu) {
           const className = getNodeName(node);
@@ -83,5 +83,5 @@ module.exports = {
       ClassDeclaration: checkForViolation,
       ClassExpression: checkForViolation,
     };
-  }),
+  },
 };

lib/rules/no-string-refs.js

@@ -5,7 +5,7 @@
 
 'use strict';
 
-const Components = require('../util/Components');
+const componentUtil = require('../util/componentUtil');
 const docsUrl = require('../util/docsUrl');
 const report = require('../util/report');
 
@@ -40,7 +40,7 @@ module.exports = {
     }],
   },
 
-  create: Components.detect((context, components, utils) => {
+  create(context) {
     const detectTemplateLiterals = context.options[0] ? context.options[0].noTemplateLiterals : false;
     /**
      * Checks if we are using refs
@@ -49,7 +49,7 @@ module.exports = {
      */
     function isRefsUsage(node) {
       return !!(
-        (utils.getParentES6Component() || utils.getParentES5Component())
+        (componentUtil.getParentES6Component(context) || componentUtil.getParentES5Component(context))
         && node.object.type === 'ThisExpression'
         && node.property.name === 'refs'
       );
@@ -115,5 +115,5 @@ module.exports = {
         }
       },
     };
-  }),
+  },
 };