-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[5.4] Update NULLs in Smart Search links #46395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@Denitz Testing your PR on currently installed Joomla! version is "5.4.1-dev" and I am unable to find the unique word in Step 2 above in Smart Search -- actuator and acquiesce even though they are indeed in the article in the Frontend... so I can't test your PR :/ |
|
@exlemor Do you have this article in search index? |
|
@Denitz yep absolutely: 'Article for PR 43695' unoriginal title but it's there ;) (and I have tried it more than once by clearing out the entire index, cache, LocalStorage etc - same results), |
|
@exlemor Sorry, you are doing smth wrong. The smart search 101% works in Joomla. |
|
Hi @Denitz, I appreciate that Smart Search works great. However, what can I be doing wrong? I create an article with 3-4 paragraphs, I go to Smart Search and press Index, it shows the article being indexed. Then I go to the front end and type in one of the 4 words I included and none of them appear... (and I had checked that all of the SmartSearch plugins are enabled) - on a Nightly 5.4.1-dev with just Joomla Patch Tester and Blog Sample Data installed on it... then noticing it didn't show any search results, I deleted the entire Index and asked it to re-index everything and searched again with no results? |
|
Sorry, it just means that smart search is not working, it's another issue. If you see article in index, try to search by article title. |
|
OK, I searched by Article title and then by those specific words and it's finding them :/ weird but good that's its working again. Thanks. I'll go test your PR now. |
|
I have tested this item ✅ successfully on 685b0bf This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46395. |
|
I have tested this item ✅ successfully on 685b0bf This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46395. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46395. |
|
thank you <3 |
|
✅ Final test before merge with JBT, seen the problem before, graft this PR's full package and deleted-finish-date article is now found |
Pull Request for Issue #46260 .
Summary of Changes
Indexed link columns are no updated with NULLs, hence i.e.
publish_end_dateis not updated toNULLonce it's cleared in article.Testing Instructions
Actual result BEFORE applying this Pull Request
Step 6) Smart search does not update the finish publish date
Expected result AFTER applying this Pull Request
Step 6) Smart search should update the finish publish date and show the result again
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed