Skip to content

Conversation

@Denitz
Copy link
Contributor

@Denitz Denitz commented Nov 2, 2025

Pull Request for Issue #46260 .

Summary of Changes

Indexed link columns are no updated with NULLs, hence i.e. publish_end_date is not updated to NULL once it's cleared in article.

Testing Instructions

  1. Create an article, add a unique word and let Smart Search index it.
  2. Use the smart search and check the article is being found
  3. Add a finish publish date to the article which is before today
  4. Use the smart search again and confirm the article is not shown in the results anymore
  5. Edit the article and clear the finish publish date, article is published in frontend again
  6. Use the smart search again, the article is still not shown in the results

Actual result BEFORE applying this Pull Request

Step 6) Smart search does not update the finish publish date

Expected result AFTER applying this Pull Request

Step 6) Smart search should update the finish publish date and show the result again

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@exlemor
Copy link

exlemor commented Nov 2, 2025

@Denitz Testing your PR on currently installed Joomla! version is "‎5.4.1-dev" ‎and I am unable to find the unique word in Step 2 above in Smart Search -- actuator and acquiesce even though they are indeed in the article in the Frontend... so I can't test your PR :/

@Denitz
Copy link
Contributor Author

Denitz commented Nov 3, 2025

@exlemor Do you have this article in search index?

@exlemor
Copy link

exlemor commented Nov 3, 2025

@Denitz yep absolutely: 'Article for PR 43695' unoriginal title but it's there ;)

(and I have tried it more than once by clearing out the entire index, cache, LocalStorage etc - same results),

@Denitz
Copy link
Contributor Author

Denitz commented Nov 3, 2025

@exlemor Sorry, you are doing smth wrong. The smart search 101% works in Joomla.

@exlemor
Copy link

exlemor commented Nov 3, 2025

Hi @Denitz, I appreciate that Smart Search works great. However, what can I be doing wrong?

I create an article with 3-4 paragraphs, I go to Smart Search and press Index, it shows the article being indexed. Then I go to the front end and type in one of the 4 words I included and none of them appear... (and I had checked that all of the SmartSearch plugins are enabled) - on a Nightly 5.4.1-dev with just Joomla Patch Tester and Blog Sample Data installed on it... then noticing it didn't show any search results, I deleted the entire Index and asked it to re-index everything and searched again with no results?

@Denitz
Copy link
Contributor Author

Denitz commented Nov 3, 2025

Sorry, it just means that smart search is not working, it's another issue. If you see article in index, try to search by article title.

@exlemor
Copy link

exlemor commented Nov 3, 2025

OK, I searched by Article title and then by those specific words and it's finding them :/ weird but good that's its working again. Thanks. I'll go test your PR now.

@exlemor
Copy link

exlemor commented Nov 3, 2025

I have tested this item ✅ successfully on 685b0bf

I was able to test this PR successfully - thanks @Denitz for your help and the PR/code.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46395.

@ceford
Copy link
Contributor

ceford commented Nov 4, 2025

I have tested this item ✅ successfully on 685b0bf


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46395.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46395.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Nov 4, 2025
@coolcat-creations
Copy link
Contributor

thank you <3

@muhme
Copy link
Contributor

muhme commented Nov 6, 2025

✅ Final test before merge with JBT, seen the problem before, graft this PR's full package and deleted-finish-date article is now found

@muhme muhme merged commit 95a83b5 into joomla:5.4-dev Nov 6, 2025
61 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Nov 6, 2025
@muhme muhme added this to the Joomla! 5.4.1 milestone Nov 6, 2025
@muhme
Copy link
Contributor

muhme commented Nov 6, 2025

Thank you @Denitz for your contribution. Thank you @exlemor and @ceford for testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants