[5.4] PHP8.5 deprecated code

[dgrammatiko]

Pull Request for Issue # .

Summary of Changes

Better variable handling to eliminate the deprecation warnings on PHP 8.5

Deprecated: Using null as an array offset is deprecated, use an empty string instead in xxx/libraries/src/HTML/Helpers/Select.php on line 495

Testing Instructions

Open the local url administrator/index.php?option=com_menus&view=item&client_id=0&layout=edit&id=101 and check the right sidebar for deprecations (PHP8.5 required and error reporting to max)

Actual result BEFORE applying this Pull Request

Deprecations logged

Expected result AFTER applying this Pull Request

No deprecations

Link to documentations

Please select:

• Documentation link for docs.joomla.org:

• No documentation changes for docs.joomla.org needed

• Pull Request link for manual.joomla.org:

• No documentation changes for manual.joomla.org needed

@richard67

[richard67]

@joomdonation As you have tested the other 2 PRs of the same kind: Could you also test this one? Thanks in advance.

[joomdonation]

@richard67 Yes. Will look at it and test it later today

[joomdonation]

I have tested this item ✅ successfully on 7b5fbde

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46137.}

[brianteeman]

I have tested this item ✅ successfully on 7b5fbde

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46137.}

[richard67]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46137.}

[heelc29]

Prevents Warning: Undefined array key

[richard67]

Back to pending as the PR has received changes.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46137.}

[richard67]

@joomdonation @brianteeman Could you test again? The PR has received some changes. Thanks in advance.

[joomdonation]

@heelc29 @richard67 The latest changes are not needed. $options['option.attr'], $options['option.id'].... are initialized with it default value by this array https://github.com/joomla/joomla-cms/blob/5.4-dev/libraries/src/HTML/Helpers/Select.php#L34-L47, so using isset as in the last changes is not necessary at all. I would revert the last changes and set the PR back to RTC again

[dgrammatiko]

I have reverted back to 7b5fbde

[richard67]

@joomdonation Could you give it a quick retest just to be sure before we set RTC again? Thanks in advance.

[joomdonation]

Tested it again and it is working. So I set this back to RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46137.}

[muhme]

Final test before merge using JBT php8.5-rc

• Seen 4 Deprecated messages from two different line numbers before PR on
  'administrator/index.php?option=com_menus&view=item&client_id=0&layout=edit&id=101s'
• Graft PR's full packge
  • ✅ no Deprecated anymore, not in any tab, opening menu item, creating new, trashing, filtering and deleting menu item is still working

[muhme]

Thank you @dgrammatiko for your contribution. Thank you @joomdonation and @heelc29 for supporting. Thank you @brianteeman, @heelc29 and @joomdonation for testing.