-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[6.0] Smart Search: Removing dependency on CMSObject #43795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Which of these methods are regularly used in smart search plugins? Because we'll need to explicitly call out b/c docs in those with docs. |
|
None. The state object normally is only used internally from Smart Search. We've not been using the CMSObject stuff for some time already, at least since 3.10. It's just that no one changed it to a stdClass in time for a major release so far. |
|
Can you document this change in the manual? |
|
I have tested this item ✅ successfully on fe77bce This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43795. |
|
I have tested this item ✅ successfully on 80e60dc This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43795. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43795. |
Summary of Changes
The
CMSObjectclass has been deprecated for a long time and for 6.0, we want to remove it as much as possible. This PR removes it from Smart Search.Testing Instructions
Apply the PR and run the indexer, look at statistics and search in the frontend and see, that everything still works as expected.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org: Documentation for removal of CMSObject from core code Manual#380
No documentation changes for manual.joomla.org needed