Skip to content

Conversation

@Hackwar
Copy link
Member

@Hackwar Hackwar commented Jul 15, 2024

Summary of Changes

The CMSObject class has been deprecated for a long time and for 6.0, we want to remove it as much as possible. This PR removes it from Smart Search.

Testing Instructions

Apply the PR and run the indexer, look at statistics and search in the frontend and see, that everything still works as expected.

Link to documentations

Please select:

@wilsonge
Copy link
Contributor

Which of these methods are regularly used in smart search plugins? Because we'll need to explicitly call out b/c docs in those with docs.

@Hackwar
Copy link
Member Author

Hackwar commented Jul 15, 2024

None. The state object normally is only used internally from Smart Search. We've not been using the CMSObject stuff for some time already, at least since 3.10. It's just that no one changed it to a stdClass in time for a major release so far.

@laoneo
Copy link
Member

laoneo commented Aug 14, 2024

Can you document this change in the manual?

@Hackwar Hackwar added Feature b/c break This item changes the behavior in an incompatible why. HEADS UP labels Nov 23, 2024
@Bodge-IT
Copy link
Contributor

Bodge-IT commented Feb 5, 2025

I have tested this item ✅ successfully on fe77bce

Indexer continued to work after wiped index.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43795.

@QuyTon
Copy link
Contributor

QuyTon commented Feb 6, 2025

I have tested this item ✅ successfully on 80e60dc


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43795.

@QuyTon
Copy link
Contributor

QuyTon commented Feb 6, 2025

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43795.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Feb 6, 2025
@Bodge-IT Bodge-IT merged commit e2004d4 into joomla:6.0-dev Feb 12, 2025
3 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Feb 12, 2025
@QuyTon QuyTon added this to the Joomla! 6.0.0 milestone Feb 12, 2025
@Hackwar Hackwar deleted the 6.0-finder-cmsobj branch March 3, 2025 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

b/c break This item changes the behavior in an incompatible why. HEADS UP Feature PR-6.0-dev

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants