Tb 202 investigate open him core rerun bug fix #1210
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## ft-pending-async #1210 +/- ##
====================================================
- Coverage 87.00% 86.76% -0.24%
====================================================
Files 89 89
Lines 6002 6024 +22
====================================================
+ Hits 5222 5227 +5
- Misses 780 797 +17
☔ View full report in Codecov by Sentry. |
nour-borgi
suggested changes
Oct 11, 2023
Contributor
nour-borgi
left a comment
nour-borgi
left a comment
There was a problem hiding this comment.
Looks nice! we tested it also, just few comments and please lint 🚀
nour-borgi
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.