added Pending Async as status for transaction #1207
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bradsawadye
reviewed
Sep 13, 2023
bradsawadye
reviewed
Sep 13, 2023
bradsawadye
reviewed
Sep 13, 2023
bradsawadye
reviewed
Sep 13, 2023
Contributor
|
@brett-onions looks good. Please add some tests |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1207 +/- ##
==========================================
+ Coverage 86.95% 87.00% +0.05%
==========================================
Files 89 89
Lines 5994 6002 +8
==========================================
+ Hits 5212 5222 +10
+ Misses 782 780 -2
☔ View full report in Codecov by Sentry. |
nour-borgi
suggested changes
Sep 25, 2023
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
brett-onions
dismissed stale reviews from nour-borgi and arran-standish
via
07b84a5
Collaborator
|
this is pending bug fix https://jembiprojects.jira.com/browse/TB-202 |
…HIM-Response-Header adding empty header obj to pass condition
MatthewErispe
previously approved these changes
Oct 5, 2023
Collaborator
MatthewErispe
left a comment
MatthewErispe
left a comment
There was a problem hiding this comment.
@brett-onions happy with the bug fix change
…rerun-bug-fix Tb 202 investigate open him core rerun bug fix
nour-borgi
approved these changes
Oct 13, 2023
MatthewErispe
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating backend to allow transaction status of "Pending Async" TB-162