Skip to content

Conversation

@benjaminum
Copy link
Contributor

Type

  • Bug fix (non-breaking change which fixes an issue): Fixes #
  • New feature (non-breaking change which adds functionality). Resolves #
  • Breaking change (fix or feature that would cause existing functionality to not work as expected) Resolves #

Motivation and Context

Checklist:

  • I have run python util/check_style.py --apply to apply Open3D code style
    to my code.
  • This PR changes Open3D behavior or adds new functionality.
    • Both C++ (Doxygen) and Python (Sphinx / Google style) documentation is
      updated accordingly.
    • I have added or updated C++ and / or Python unit tests OR included test
      results
      (e.g. screenshots or numbers) here.
  • I will follow up and update the code if CI fails.
  • For fork PRs, I have selected Allow edits from maintainers.

Description

Add header for building tests on ubuntu 24.04 to fix unknown type uint8_t

@update-docs
Copy link

update-docs bot commented Jun 30, 2024

Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes.

@benjaminum
Copy link
Contributor Author

CI failures

MacOS (macos-12, OFF)
2024-06-30T15:29:11.1077240Z [  FAILED  ] 1 test, listed below:
2024-06-30T15:29:11.1078950Z [  FAILED  ] Registration/RegistrationPermuteDevices.ICPColored/0, where GetParam() = 8-byte object <00-00 00-00 00-00 00-00>
2
MacOS (macos-14, ON)
Downloading wrapt-1.16.0-cp311-cp311-macosx_11_0_arm64.whl (38 kB)
ERROR: THESE PACKAGES DO NOT MATCH THE HASHES FROM THE REQUIREMENTS FILE. If you have updated the package versions, please update the hashes. Otherwise, examine the package contents carefully; someone may have tampered with them.
    unknown package:
        Expected sha256 5dca8291125c0151bf426a2789689e02c623ce4540432cf66a073d361d3d6870
             Got        3d385596d593dbc7c68e806c2da7d4ddbf9e2dab225306b8578987897af2c7de
Windows (ON, OFF, ON, Debug)
[C:\Open3D\build\cpp\open3d\Open3D.vcxproj] [C:\Open3D\build\examples\cpp\build-examples-iteratively.vcxproj]
2024-06-30T15:29:51.7640672Z   
2024-06-30T15:29:51.7640969Z   
2024-06-30T15:29:51.7641633Z          "C:\Open3D\build\examples\cpp\RealSenseRecorder.vcxproj" (default target) (1) ->
2024-06-30T15:29:51.7642793Z          "C:\Open3D\build\cpp\open3d\Open3D.vcxproj" (default target) (6) ->
2024-06-30T15:29:51.7643708Z          (Link target) -> 
2024-06-30T15:29:51.7645206Z LINK : fatal error LNK1189: library limit of 65535 objects exceeded [C:\Open3D\build\cpp\open3d\Open3D.vcxproj] [C:\Open3D\build\examples\cpp\build-examples-iteratively.vcxproj]
2024-06-30T15:29:51.7646732Z   
2024-06-30T15:29:51.7647052Z       247 Warning(s)
2024-06-30T15:29:51.7647429Z       1 Error(s)
2024-06-30T15:29:51.7647794Z   
2024-06-30T15:29:51.7648123Z   Time Elapsed 00:00:17.21
2024-06-30T15:29:51.7648679Z   
2024-06-30T15:29:51.7649224Z   -- [Iterative example build] deleting: RealSenseRecorder.
2024-06-30T15:29:51.7650275Z   Building Custom Rule D:/a/Open3D/Open3D/examples/cpp/CMakeLists.txt
2024-06-30T15:29:51.7992284Z C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\MSBuild\Microsoft\VC\v160\Microsoft.CppCommon.targets(241,5): error MSB8066: Custom build for 'C:\Open3D\build\CMakeFiles\faca83c178c8d466bb0552f685145818\build-examples-iteratively.rule;D:\a\Open3D\Open3D\examples\cpp\CMakeLists.txt' exited with code -1. [C:\Open3D\build\examples\cpp\build-examples-iteratively.vcxproj]
Windows (ON, OFF, OFF,Release)
[  FAILED  ] 1 test, listed below:
[  FAILED  ] Registration/RegistrationPermuteDevices.ICPColored/0, where GetParam() = 8-byte object <00-00 00-00 00-00 00-00>
ubuntu-sycl (OFF) ??? See [ubuntu-sycl (OFF)](https://github.com/isl-org/Open3D/actions/runs/9732787977/job/26858875740?pr=6847#logs)
Build and run (2-bionic)
ERROR: (gcloud.compute.os-login.ssh-keys.remove) Cannot find requested SSH key.
Build and run (3-ml-shared-bionic)
[  FAILED  ] 4 tests, listed below:
[  FAILED  ] TriangleMesh/TriangleMeshPermuteDevices.ComputeTriangleAreas/2, where GetParam() = 8-byte object <01-00 00-00 01-00 00-00>
[  FAILED  ] TriangleMesh/TriangleMeshPermuteDevices.ComputeTriangleAreas/1, where GetParam() = 8-byte object <01-00 00-00 00-00 00-00>
[  FAILED  ] TriangleMesh/TriangleMeshPermuteDevices.RemoveNonManifoldEdges/1, where GetParam() = 8-byte object <01-00 00-00 00-00 00-00>
[  FAILED  ] TriangleMesh/TriangleMeshPermuteDevices.RemoveNonManifoldEdges/2, where GetParam() = 8-byte object <01-00 00-00 01-00 00-00>

4 FAILED TESTS

Build and run (4-shared-bionic)
[  FAILED  ] 4 tests, listed below:
[  FAILED  ] TriangleMesh/TriangleMeshPermuteDevices.ComputeTriangleAreas/1, where GetParam() = 8-byte object <01-00 00-00 00-00 00-00>
[  FAILED  ] TriangleMesh/TriangleMeshPermuteDevices.RemoveNonManifoldEdges/1, where GetParam() = 8-byte object <01-00 00-00 00-00 00-00>
[  FAILED  ] TriangleMesh/TriangleMeshPermuteDevices.RemoveNonManifoldEdges/2, where GetParam() = 8-byte object <01-00 00-00 01-00 00-00>
[  FAILED  ] TriangleMesh/TriangleMeshPermuteDevices.ComputeTriangleAreas/2, where GetParam() = 8-byte object <01-00 00-00 01-00 00-00>

4 FAILED TESTS

Build and run (5-ml-focal)
ERROR: (gcloud.compute.os-login.ssh-keys.remove) Cannot find requested SSH key.
Test wheel CPU (3.11, false)
 File "/home/runner/work/Open3D/Open3D/open3d_test.venv/lib/python3.11/site-packages/numpy/__init__.py", line 397, in __getattr__
    raise AttributeError(
AttributeError: `np.string_` was removed in the NumPy 2.0 release. Use `np.bytes_` instead.. Did you mean: 'strings'?

@benjaminum benjaminum requested a review from ssheorey July 1, 2024 11:01
@ssheorey
Copy link
Member

ssheorey commented Jul 1, 2024

Thanks for collecting all the CI errors.

Windows CI errors:

https://learn.microsoft.com/en-us/cpp/error-messages/tool-errors/linker-tools-error-lnk1189?view=msvc-170

We need to split the Open3D library....

Ubuntu CUDA errors:

The new TriangleMesh/TriangleMeshPermuteDevices.ComputeTriangleAreas/ and TriangleMesh/TriangleMeshPermuteDevices.RemoveNonManifoldEdges/1 doesn't work on CUDA. Need to debug and fix.

Test wheel CPU errors:: numpy.strings_ is from tensorboard. Should be fixed on tensorflow / tensorboard update in Python 3.12 PR.

@ssheorey ssheorey merged commit 160209d into main Jul 8, 2024
@ssheorey ssheorey deleted the benjaminum/fix_missing_uint8_t branch July 8, 2024 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants