Implement t::geometry::TriangleMesh::RemoveUnreferencedVertices #6640
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes. |
benjaminum
requested changes
Feb 11, 2024
nsaiapova
force-pushed
the
wip/remove-unreferenced-verts
branch
from
eee30b6 to
28aeb0f
Compare
Collaborator
Author
|
In the last push I also added "device" argument to tensor initialization in cpp tests. |
ssheorey
approved these changes
Feb 27, 2024
Member
ssheorey
left a comment
ssheorey
left a comment
There was a problem hiding this comment.
Looks good! Some minor comments.
| def test_remove_unreferenced_vertices(device): | ||
| for int_t in [o3c.int32, o3c.int64]: | ||
| for float_t in [o3c.float32, o3c.float64]: | ||
| check_no_unreferenced_vertices(device, int_t, float_t) |
Member
There was a problem hiding this comment.
You can use nested parametrize in pytest. No need for the two for loops.
@pytest.mark.parametrize("device", list_devices())
@pytest.mark.parametrize("int_t", (o3c.int32, o3c.int64))
@pytest.mark.parametrize("float_t", (o3c.float32, o3c.float64))| for (auto item : GetVertexAttr()) { | ||
| SetVertexAttr(item.first, item.second.IndexGet({vertex_mask})); | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
nit: Add LogDebug message about how many vertices were removed.
|
|
||
| if (!HasTriangleIndices() || GetTriangleIndices().GetLength() == 0) { | ||
| utility::LogWarning( | ||
| "[RemoveUnreferencedVertices] TriangleMesh has no triangles."); |
Member
There was a problem hiding this comment.
"[RemoveUnreferencedVertices] TriangleMesh has no triangles. Removing all vertices."
benjaminum
approved these changes
Mar 5, 2024
nsaiapova
force-pushed
the
wip/remove-unreferenced-verts
branch
2 times, most recently
from
e60a07a to
664ef13
Compare
The algorithm mimics the one in geometry::TriangleMesh::RemoveUnreferencedVertices. We first build a mask of vertices and then update all vertex attributes by that mask. Triangles are left untouched.
nsaiapova
force-pushed
the
wip/remove-unreferenced-verts
branch
from
664ef13 to
d477ab8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The algorithm mimics the one in
geometry::TriangleMesh::RemoveUnreferencedVertices. We first build a mask of vertices and then update all vertex attributes by that mask. Triangles are left untouched.
Type
Motivation and Context
Implement missing method t::geometry::TriangleMesh::RemoveUnreferencedVertices. The method is defined in the legacy API.
Checklist:
python util/check_style.py --applyto apply Open3D code styleto my code.
updated accordingly.
results (e.g. screenshots or numbers) here.
Description