Skip to content

Conversation

@QuentinTorg
Copy link
Contributor

@QuentinTorg QuentinTorg commented Jun 12, 2023

Set the GLIBCXX_USE_CXX11_ABI ON as default independent of the value of BUILD_SYCL_MODULE

Type

Motivation and Context

Previously the CXX11 ABI was off by default. #4387 was merged to fix this issue. Later, a regression was introduced with #5081 that made the default CXX11 ABI conditional on another variable. This once again changed the default CXX11 ABI back to the problematic case if no parameter was specified

Checklist:

  • I have run python util/check_style.py --apply to apply Open3D code style
    to my code.
  • This PR changes Open3D behavior or adds new functionality.
    • Both C++ (Doxygen) and Python (Sphinx / Google style) documentation is
      updated accordingly.
    • I have added or updated C++ and / or Python unit tests OR included test
      results
      (e.g. screenshots or numbers) here.
  • I will follow up and update the code if CI fails.
  • For fork PRs, I have selected Allow edits from maintainers.

Description

This PR removes the conditional check so that the CXX11 ABI will be used by default


This change is Reviewable

@update-docs
Copy link

update-docs bot commented Jun 12, 2023

Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes.

@ssheorey
Copy link
Member

Hi @QuentinTorg thanks for the bug fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants