IBX-5705: Used SecurityPass to define Guard authentication provider (#265)

For more details see https://issues.ibexa.co/browse/IBX-5705 and #265

Author: Nattfarinn

src/bundle/Core/DependencyInjection/Compiler/SecurityPass.php

@@ -10,6 +10,7 @@
 use Ibexa\Contracts\Core\Repository\UserService;
 use Ibexa\Core\MVC\Symfony\Security\Authentication\AnonymousAuthenticationProvider;
 use Ibexa\Core\MVC\Symfony\Security\Authentication\DefaultAuthenticationSuccessHandler;
+use Ibexa\Core\MVC\Symfony\Security\Authentication\GuardRepositoryAuthenticationProvider;
 use Ibexa\Core\MVC\Symfony\Security\Authentication\RememberMeRepositoryAuthenticationProvider;
 use Ibexa\Core\MVC\Symfony\Security\Authentication\RepositoryAuthenticationProvider;
 use Ibexa\Core\MVC\Symfony\Security\HttpUtils;
@@ -32,6 +33,7 @@ public function process(ContainerBuilder $container)
     {
         if (!($container->hasDefinition('security.authentication.provider.dao') &&
               $container->hasDefinition('security.authentication.provider.rememberme') &&
+              $container->hasDefinition('security.authentication.provider.guard') &&
               $container->hasDefinition('security.authentication.provider.anonymous'))) {
             return;
         }
@@ -73,6 +75,13 @@ public function process(ContainerBuilder $container)
             [$permissionResolverRef]
         );
 
+        $guardAuthenticationProviderDef = $container->findDefinition('security.authentication.provider.guard');
+        $guardAuthenticationProviderDef->setClass(GuardRepositoryAuthenticationProvider::class);
+        $guardAuthenticationProviderDef->addMethodCall(
+            'setPermissionResolver',
+            [$permissionResolverRef]
+        );
+
         $anonymousAuthenticationProviderDef = $container->findDefinition('security.authentication.provider.anonymous');
         $anonymousAuthenticationProviderDef->setClass(AnonymousAuthenticationProvider::class);
         $anonymousAuthenticationProviderDef->addMethodCall(

src/bundle/Core/Resources/config/security.yml

@@ -53,11 +53,6 @@ services:
         tags:
             - { name: kernel.event_subscriber }
 
-    Ibexa\Core\MVC\Symfony\Security\Authentication\GuardRepositoryAuthenticationProvider:
-        decorates: security.authentication.provider.guard
-        calls:
-            - ['setPermissionResolver', ['@Ibexa\Contracts\Core\Repository\PermissionResolver']]
-
     ibexa.security.user_provider: '@Ibexa\Core\MVC\Symfony\Security\User\UsernameProvider'
     ibexa.security.user_provider.username: '@Ibexa\Core\MVC\Symfony\Security\User\UsernameProvider'
     ibexa.security.user_provider.email: '@Ibexa\Core\MVC\Symfony\Security\User\EmailProvider'

tests/bundle/Core/DependencyInjection/Compiler/SecurityPassTest.php

@@ -22,6 +22,7 @@ protected function setUp(): void
         parent::setUp();
         $this->setDefinition('security.authentication.provider.dao', new Definition());
         $this->setDefinition('security.authentication.provider.rememberme', new Definition());
+        $this->setDefinition('security.authentication.provider.guard', new Definition());
         $this->setDefinition('security.authentication.provider.anonymous', new Definition());
         $this->setDefinition('security.http_utils', new Definition());
         $this->setDefinition('security.authentication.success_handler', new Definition());
@@ -54,6 +55,11 @@ public function testAlteredDaoAuthenticationProvider()
             'setPermissionResolver',
             [new Reference(PermissionResolver::class)]
         );
+        $this->assertContainerBuilderHasServiceDefinitionWithMethodCall(
+            'security.authentication.provider.guard',
+            'setPermissionResolver',
+            [new Reference(PermissionResolver::class)]
+        );
         $this->assertContainerBuilderHasServiceDefinitionWithMethodCall(
             'security.authentication.provider.anonymous',
             'setPermissionResolver',