Emit disconnected event instead of error when ECONNRESET (#966)

* Emit disconnected event instead of error when ECONNRESET

ECONNRESET means the other side of the TCP conversation abruptly
closed its end of the connection.

If we get an ECONNRESET error from the proxy request and the
socket is destroyed this means that the client has closed
his connection, and emit this as an error can lead to
confusion and hacks to filter that kind of message.

I think that the best we can do is abort and emit another event,
so if any caller wants to handle with that kind of error, he can
by listen the disconnected event.

#813

* code standards, move econnreset check, change ev name

Author: Deividy

lib/http-proxy/passes/web-incoming.js

@@ -137,6 +137,11 @@ web_o = Object.keys(web_o).map(function(pass) {
     proxyReq.on('error', proxyError);
 
     function proxyError (err){
+      if (req.socket.destroyed && err.code === 'ECONNRESET') {
+        server.emit('econnreset', err, req, res, options.target);
+        return proxyReq.abort();
+      }
+
       if (clb) {
         clb(err, req, res, options.target);
       } else {

test/lib-http-proxy-passes-web-incoming-test.js

@@ -229,7 +229,7 @@ describe('#createProxyServer.web() using own http server', function () {
 
     var started = new Date().getTime();
     function requestHandler(req, res) {
-      proxy.once('error', function (err, errReq, errRes) {
+      proxy.once('econnreset', function (err, errReq, errRes) {
         proxyServer.close();
         expect(err).to.be.an(Error);
         expect(errReq).to.be.equal(req);