feat(derived-columns): Infix notation support

[MadhuVK]

Short description of the changes

Upgrade the Derived Column validator to recognize the new infix notation.

• Derived Columns are also known as Calculated Fields in the Honeycomb product.

Relevant Release: https://github.com/honeycombio/honeycomb-derived-column-validator/releases/tag/v0.1.0

How to verify that this has the expected result

Test automation should have a new infix notation DC

Smoke Test:

• Create a resource with a Derived Column using new infix notation

Documentation

https://docs.honeycomb.io/reference/calculated-field-formula/syntax/
https://docs.honeycomb.io/reference/derived-column-formula/syntax/

[jharley]

This looks pretty good, thank you! Couple of things:

1. The provider is still using the old "derived column" terminology so updating the PR name and description to reflect that would be good
2. I'm not sure we want to be encouraging mixing operator types from a best practises standpoint. I know it works, but people look to these examples as a guide.
3. the documentation for the resource itself should be updated also (docs/resources/derived_column.md)

[jharley]

do we want to be encouraging people to mix forms? From a best practise standpoint that feels a bit messy to me

[MadhuVK]

Good point - I'll update the example to avoid mixing as much as possible.

• Some functions don't have an equivalent infix operator so things like IF(foo, bar) might continue to exist though.

[MadhuVK]

@jharley updated:

1. Stuck with Derived Column verbiage, but cross-reference the new product name, and provide both relevant documentation links.
2. Removed mixing notation - IF/EXISTS don't have an equivalent so continue to use them.
3. I didn't make any augmentations to the TF provider resource docs - the current example is just LOG10($foo) and already has a reference to the syntax docs that reference the new notation + equivalents.
   i. Is there something specific you wish to see here? Happy to expand out a bit with a more complete example if you think its appropriate.
   ii. https://registry.terraform.io/providers/honeycombio/honeycombio/latest/docs/resources/derived_column

[jharley]

@MadhuVK thank you! Looks like a test is failing now though so something tidy up.

Is there something specific you wish to see here?

Ah, you're right those examples just aren't great currently. :\ We can leave it as unless you have time to add a few examples.

[jharley]

Nice ✨

[jharley]

Ah, nice catch! 🙏🏻

[jharley]

Thank you!