Skip to content

Conversation

@erichosick
Copy link
Contributor

Description

We're building out a JSON schema -> Smart Tags File utility. We want to verify that the Smart Tags File fully compiles so we make a call to makeJSONPgSmartTagsPlugin. If that call fails, we want to throw the exception and stop building the Smart Tags File. Currently, there are just warning messages.

Exporting the pgSmartTagRulesFromJSON function gives the ability to do this.

Performance impact

There should be no impact on performance.

Security impact

unknown

Checklist

  • My code matches the project's code style and yarn lint:fix passes.
  • I've added tests for the new feature, and yarn test passes.
  • I have detailed the new feature in the relevant documentation.
  • I have added this feature to 'Pending' in the RELEASE_NOTES.md file (if one exists).
  • If this is a breaking change I've explained why.

@erichosick erichosick requested a review from benjie March 17, 2021 14:16
@erichosick erichosick marked this pull request as draft March 22, 2021 19:01
@erichosick erichosick marked this pull request as ready for review March 22, 2021 19:02
@benjie benjie changed the title Export pgSmartTagRulesFromJSON enabling developers to do validation and handle any exception themselves. feat: export pgSmartTagRulesFromJSON Apr 15, 2021
@benjie benjie merged commit 48e07cd into graphile:v4 Apr 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants