-
-
Notifications
You must be signed in to change notification settings - Fork 129
feat(deps): support for GraphQL v15 #689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I've added code that wraps all our old descriptions so that the schema diff is reduced there; |
benjie
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've reviewed everything except packages/graphile-utils/tests/snapshots/ExtendSchemaPlugin-pg.test.js.snap, packages/graphile-utils/tests/snapshots/makeAddPgTableConditionPlugin.test.js.snap and packages/postgraphile-core/tests/integration/schema/snapshots/simplePrint.test.js.snap. Those diffs are too large to sensibly compare given GraphQL v15 reorders the schema (this is an argument for lexicographically sorting the GraphQL schema, but we've chosen not to do this because we want to know where we're adding the fields).
Adds support for GraphQL v15; to minimise the schema diffs it also wraps all of our built-in descriptions (to match GraphQL v14's output).
Performance and security impact are dictated by GraphQL v15 vs GraphQL v14 - but ultimately this is the user's choice so is beyond the scope of this PR.