fix(graphile-build-pg): add more numeric casting exceptions

[wesselvdv]

resolves #660

I couldn't find any test(s) related to this portion of code?

[benjie]

Good catch! We mostly use integration tests, so please add a few columns to

graphile-engine/packages/postgraphile-core/__tests__/kitchen-sink-schema.sql

Lines 253 to 289 in 16d7b30

	create table b.types (
	id serial primary key,
	"smallint" smallint not null,
	"bigint" bigint not null,
	"numeric" numeric not null,
	"decimal" decimal not null,
	"boolean" boolean not null,
	"varchar" varchar not null,
	"enum" b.color not null,
	"enum_array" b.color[] not null,
	"domain" a.an_int not null,
	"domain2" b.another_int not null,
	"text_array" text[] not null,
	"json" json not null,
	"jsonb" jsonb not null,
	"nullable_range" numrange,
	"numrange" numrange not null,
	"daterange" daterange not null,
	"an_int_range" a.an_int_range not null,
	"timestamp" timestamp not null,
	"timestamptz" timestamptz not null,
	"date" date not null,
	"time" time not null,
	"timetz" timetz not null,
	"interval" interval not null,
	"interval_array" interval[] not null,
	"money" money not null,
	"compound_type" c.compound_type not null,
	"nested_compound_type" b.nested_compound_type not null,
	"nullable_compound_type" c.compound_type,
	"nullable_nested_compound_type" b.nested_compound_type,
	"point" point not null,
	"nullablePoint" point,
	"inet" inet,
	"cidr" cidr,
	"macaddr" macaddr
	);

Data to here:

graphile-engine/packages/postgraphile-core/__tests__/kitchen-sink-data.sql

Line 63 in 16d7b30

insert into b.types values (

And adjust the operations here:

https://github.com/graphile/graphile-engine/blob/v4/packages/postgraphile-core/__tests__/fixtures/queries/types.graphql

And here:

https://github.com/graphile/graphile-engine/blob/v4/packages/postgraphile-core/__tests__/fixtures/mutations/types.graphql

Then run

# To appease prettier
yarn lint:fix

# To run the tests and update the snapshots
cd packages/postgraphile-core
yarn test -u

And finally validate that these snapshot additions are what you'd expect.

[wesselvdv]

@benjie Thanks for the pointers. Also added the reg types to pgtypes plugin so they're not shown as BigFloat types.

[wesselvdv]

I can't seem to easily support regrole and regnamespace without breaking support for pg 9.4

[benjie]

I can't seem to easily support regrole and regnamespace without breaking support for pg 9.4

Is that just for the tests, or functionality? If just tests, skip that for now (or add them to a pg10.* test)

[wesselvdv]

I can't seem to easily support regrole and regnamespace without breaking support for pg 9.4

Is that just for the tests, or functionality? If just tests, skip that for now (or add them to a pg10.* test)

It's just for the tests, seeing that adding the oid type to the pgTypes plugin doesn't cause any breaking behaviour.

[wesselvdv]

@benjie Looks like I managed to get an all green on the tests. Let me know if something is not quite up to snuff, then I can always rework.

[benjie]

Looking good 🙌

[benjie]

Please do not rebase or edit history from this point forward. I will squash and merge when the time comes.

[benjie]

@wesselvdv @-me when you're ready for a re-review. Though you've reset network_id_seq, the newly created pg10.types table still doesn't have the sequence reset for types_id_seq commented above.

[wesselvdv]

@benjie I added the proper reset for types_id_seq and corrected the network_id_seq one.

[benjie]

Almost there 🙌

[benjie]

Fantastic 🙌 Thanks!