Skip to content

fix(watch): handle errors during watchSchema #624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
benjie merged 1 commit into from
May 12, 2020
Merged

fix(watch): handle errors during watchSchema #624

benjie merged 1 commit into from
May 12, 2020

Conversation

@benjie
Copy link
Member

@benjie benjie commented May 12, 2020

Fixes graphile/crystal#1276

Mostly this wraps the this.buildSchema() call with a try/catch that calls unwatchSchema on error.

@benjie benjie mentioned this pull request May 12, 2020
Closed
3 tasks
@benjie benjie merged commit 4ef1b7b into v4 May 12, 2020
@benjie benjie deleted the fix-watch-retry-lockup branch May 12, 2020 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Postgraphile stops retrying when --watch is specified

2 participants

@benjie