Skip to content

Conversation

@timvaillancourt
Copy link
Collaborator

@timvaillancourt timvaillancourt commented Aug 20, 2020

Description

The gh-ost-build-deploy-tarball CI job is now running under Debian buster and is no longer creating stretch and jessie tarballs like before

This PR continues a hack that was previously added for jessie/stretch until a better solution emerges

In case this PR introduced Go code changes:

  • contributed code is using same conventions as original code
  • script/cibuild returns with no formatting errors, build errors or unit test errors.

Copy link
Member

@eguevara eguevara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just left a comment on whether stretch is needed? I already see both in github-builds prior to aug 19.

@timvaillancourt timvaillancourt merged commit ce03757 into master Aug 20, 2020
@timvaillancourt timvaillancourt deleted the fix-buster-tarball-build branch August 20, 2020 20:08
@shlomi-noach
Copy link
Contributor

LOL

Copy link

@Chawniseyler Chawniseyler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants