Skip to content

chore: fix function names in comment #1405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timvaillancourt merged 2 commits into from
Apr 14, 2024
Merged

chore: fix function names in comment #1405

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
912637d
chore: fix function names in comment
mountcount Apr 9, 2024
8819009
Merge branch 'master' into master
timvaillancourt Apr 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion go/base/context.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -772,7 +772,7 @@ func (this *MigrationContext) ReadMaxLoad(maxLoadList string) error {
return nil
}

// ReadMaxLoad parses the `--max-load` flag, which is in multiple key-value format,
// ReadCriticalLoad parses the `--max-load` flag, which is in multiple key-value format,
// such as: 'Threads_running=100,Threads_connected=500'
// It only applies changes in case there's no parsing error.
func (this *MigrationContext) ReadCriticalLoad(criticalLoadList string) error {
Expand Down
2 changes: 1 addition & 1 deletion go/logic/applier.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -796,7 +796,7 @@ func (this *Applier) StartSlaveIOThread() error {
return nil
}

// StartSlaveSQLThread is applicable with --test-on-replica
// StopSlaveSQLThread is applicable with --test-on-replica
func (this *Applier) StopSlaveSQLThread() error {
query := `stop /* gh-ost */ slave sql_thread`
this.migrationContext.Log.Infof("Verifying SQL thread is stopped")
Expand Down
2 changes: 1 addition & 1 deletion go/logic/throttler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,7 +284,7 @@ func (this *Throttler) criticalLoadIsMet() (met bool, variableName string, value
return false, variableName, value, threshold, nil
}

// collectReplicationLag reads the latest changelog heartbeat value
// collectThrottleHTTPStatus reads the latest changelog heartbeat value
func (this *Throttler) collectThrottleHTTPStatus(firstThrottlingCollected chan<- bool) {
collectFunc := func() (sleep bool, err error) {
if atomic.LoadInt64(&this.migrationContext.HibernateUntil) > 0 {
Expand Down