fix #1039 #1030: add shared-mode lock in query ReadMigrationRangeValues to avoid losing data #1040
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
so quick，nubility！ |
Contributor
|
#1054 |
2 tasks
Contributor
|
Any progress? |
Collaborator
|
@Fanduzi the core issue was probably resolved in another PR. Please test and let me know I'll leave this open in case this locking is still needed. For now I've avoided it because the impact of the lock is hard to quantify |
Contributor
In my opinion, this lock is no longer needed. #1141 solves the problem perfectly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related #1039 #1030 ..
This PR is to avoid losing data when gh-ost in MySQL with semi-sync replication enabled.
Reason
In mysql with a semi-sync slave, transactions may be in uncommitted state with 'Waiting for semi-sync ACK from slave' wait, though its related binlog event has already been handled and discarded by gh-ost BinlogStreamer. If gh-ost ReadMigrationRangeValues executes before the transactions finnally committed, the uncommitted rows is lost.
Fix
Add a shared mode lock in the query of ReadMigrationRangeValues. If min/max value of the uniquekey was changed by another transaction that has not yet committed, query just waits until that transaction ends and then uses the latest values.
Thus ReadMigrationRangeValues returns the accurate value.
Thank you !