Skip to content

Commit bfb82f3

Browse files
committed
tests: update minified tests expectations
1 parent ac768ba commit bfb82f3

File tree

3 files changed

+14
-3
lines changed
  • dev-packages/browser-integration-tests/suites/integrations
    • ContextLines/noAddedLines
    • moduleMetadata

3 files changed

+14
-3
lines changed

dev-packages/browser-integration-tests/suites/integrations/ContextLines/noAddedLines/test.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,10 @@ sentryTest('should not add source context lines to errors from script files', as
1616

1717
const exception = eventData.exception?.values?.[0];
1818
const frames = exception?.stacktrace?.frames;
19-
expect(frames).toHaveLength(1);
19+
expect(frames?.length).toBeGreaterThanOrEqual(1);
20+
// Verify the subject.bundle.js frame is present
21+
expect(frames?.some(f => f.filename?.includes('subject.bundle.js'))).toBe(true);
22+
// Core assertion: no context lines should be added for script files
2023
frames?.forEach(f => {
2124
expect(f).not.toHaveProperty('pre_context');
2225
expect(f).not.toHaveProperty('context_line');

dev-packages/browser-integration-tests/suites/integrations/moduleMetadata/appliesMetadata/test.ts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,5 +7,9 @@ sentryTest('should provide module_metadata on stack frames in beforeSend', async
77
const url = await getLocalTestUrl({ testDir: __dirname });
88

99
const errorEvent = await getFirstSentryEnvelopeRequest<Event>(page, url);
10-
expect(errorEvent.extra?.['module_metadata_entries']).toEqual([{ foo: 'bar' }]);
10+
// Filter out null entries from internal Sentry frames that don't have module metadata
11+
const metadataEntries = (errorEvent.extra?.['module_metadata_entries'] as Array<unknown>)?.filter(
12+
entry => entry !== null,
13+
);
14+
expect(metadataEntries).toEqual([{ foo: 'bar' }]);
1115
});

dev-packages/browser-integration-tests/suites/integrations/moduleMetadata/appliesMetadataWithRewriteFrames/test.ts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,10 @@ sentryTest(
99
const url = await getLocalTestUrl({ testDir: __dirname });
1010

1111
const errorEvent = await getFirstSentryEnvelopeRequest<Event>(page, url);
12-
expect(errorEvent?.extra?.['module_metadata_entries']).toEqual([{ foo: 'baz' }]);
12+
// Filter out null entries from internal Sentry frames that don't have module metadata
13+
const metadataEntries = (errorEvent?.extra?.['module_metadata_entries'] as Array<unknown>)?.filter(
14+
entry => entry !== null,
15+
);
16+
expect(metadataEntries).toEqual([{ foo: 'baz' }]);
1317
},
1418
);

0 commit comments

Comments
 (0)