Skip to content

Commit 1981cec

Browse files
s1gr1ds1gr1d
committed
try fix tests
1 parent a3eeff9 commit 1981cec

File tree

4 files changed

+17
-56
lines changed

4 files changed

+17
-56
lines changed

‎dev-packages/browser-integration-tests/suites/tracing/browserTracingIntegration/interactions/template.html‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,5 @@
88
<button data-test-id="interaction-button">Click Me</button>
99
<button data-test-id="annotated-button" data-sentry-component="AnnotatedButton" data-sentry-element="StyledButton">Click Me</button>
1010
<button data-test-id="styled-button" data-sentry-element="StyledButton">Click Me</button>
11-
<script src="https://example.com/path/to/script.js"></script>
1211
</body>
1312
</html>

‎dev-packages/browser-integration-tests/suites/tracing/metrics/web-vitals-inp/assets/script.js‎

Lines changed: 4 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
const delay = (delay = 70) => e => {
1+
const blockUI = (delay = 70) => e => {
22
const startTime = Date.now();
33

44
function getElasped() {
@@ -13,17 +13,6 @@ const delay = (delay = 70) => e => {
1313
e.target.classList.add('clicked');
1414
};
1515

16-
document.querySelector('[data-test-id=slow-interaction-button]').addEventListener('click', delay(200));
17-
document.querySelector('[data-test-id=interaction-button]').addEventListener('click', delay());
18-
document.querySelector('[data-test-id=annotated-button]').addEventListener('click', delay());
19-
document.querySelector('[data-test-id=styled-button]').addEventListener('click', delay());
20-
21-
document.querySelector('[data-test-id=click-me-button]').addEventListener('click', function (e) {
22-
this.textContent = 'Clicked!';
23-
requestAnimationFrame(() => {
24-
e.target.classList.add('clicked');
25-
requestAnimationFrame(() => {
26-
this.textContent = 'Click me';
27-
});
28-
});
29-
});
16+
document.querySelector('[data-test-id=not-so-slow-button]').addEventListener('click', blockUI(200));
17+
document.querySelector('[data-test-id=slow-button]').addEventListener('click', blockUI(500));
18+
document.querySelector('[data-test-id=normal-button]').addEventListener('click', blockUI());

‎dev-packages/browser-integration-tests/suites/tracing/metrics/web-vitals-inp/template.html‎

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -5,12 +5,8 @@
55
</head>
66
<body>
77
<div>Rendered Before Long Task</div>
8-
<button data-test-id="interaction-button">Click Me</button>
9-
<button data-test-id="slow-interaction-button">Also Click Me</button>
10-
<button data-test-id="annotated-button" data-sentry-component="AnnotatedButton" data-sentry-element="StyledButton">Click Me</button>
11-
<button data-test-id="styled-button" data-sentry-element="StyledButton">Click Me</button>
12-
<button data-test-id="click-me-button">Subscribe</button>
13-
14-
<script src="https://example.com/path/to/script.js"></script>
8+
<button data-test-id="slow-button">Slow</button>
9+
<button data-test-id="not-so-slow-button" data-sentry-component="not-so-slow-button" data-sentry-element="not-so-slow-button">Not so slow</button>
10+
<button data-test-id="normal-button" data-sentry-element="NormalButton">Click Me</button>
1511
</body>
1612
</html>

‎dev-packages/browser-integration-tests/suites/tracing/metrics/web-vitals-inp/test.ts‎

Lines changed: 10 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -31,33 +31,20 @@ sentryTest('should capture an INP click event span.', async ({ browserName, getL
3131
await getFirstSentryEnvelopeRequest<SentryEvent>(page); // wait for page load
3232

3333
const spanEnvelopesPromise = getMultipleSentryEnvelopeRequests<SpanJSON>(page, 1, {
34-
// envelopeType: 'span', // todo: does not work with envelopType
34+
// envelopeType: 'span', // todo: does not work with envelopeType
3535
});
3636

37-
await page.locator('[data-test-id=interaction-button]').click();
38-
await page.locator('.clicked[data-test-id=interaction-button]').isVisible();
39-
40-
// eslint-disable-next-line no-console
41-
console.log('buttons clicked');
37+
await page.locator('[data-test-id=normal-button]').click();
38+
await page.locator('.clicked[data-test-id=normal-button]').isVisible();
4239

4340
// Page hide to trigger INP
4441
await page.evaluate(() => {
45-
// eslint-disable-next-line no-console
46-
console.log('dispatching event');
4742
window.dispatchEvent(new Event('pagehide'));
4843
});
4944

50-
// eslint-disable-next-line no-console
51-
console.log('event dispatched');
52-
5345
// Get the INP span envelope
5446
const spanEnvelopes = await spanEnvelopesPromise;
5547

56-
// eslint-disable-next-line no-console
57-
console.log('waited for envelope');
58-
59-
// expect(spanEnvelopes).toBe(1);
60-
6148
expect(spanEnvelopes).toHaveLength(1);
6249
expect(spanEnvelopes[0].op).toBe('ui.interaction.click');
6350
expect(spanEnvelopes[0].description).toBe('body > button.clicked');
@@ -92,38 +79,28 @@ sentryTest(
9279
await getFirstSentryEnvelopeRequest<SentryEvent>(page);
9380

9481
const spanEnvelopesPromise = getMultipleSentryEnvelopeRequests<SpanJSON>(page, 1, {
95-
// envelopeType: 'span',
82+
// envelopeType: 'span', // todo: does not work with envelopeType
9683
});
9784

98-
await page.locator('[data-test-id=interaction-button]').click();
99-
await page.locator('.clicked[data-test-id=interaction-button]').isVisible();
85+
await page.locator('[data-test-id=normal-button]').click();
86+
await page.locator('.clicked[data-test-id=normal-button]').isVisible();
10087

101-
// eslint-disable-next-line no-console
102-
console.log('2 - clicked first time');
103-
104-
await page.locator('[data-test-id=slow-interaction-button]').click();
105-
await page.locator('.clicked[data-test-id=slow-interaction-button]').isVisible();
106-
107-
// eslint-disable-next-line no-console
108-
console.log('2 - clicked second time');
88+
await page.locator('[data-test-id=slow-button]').click();
89+
await page.locator('.clicked[data-test-id=slow-button]').isVisible();
10990

11091
// Page hide to trigger INP
11192
await page.evaluate(() => {
11293
window.dispatchEvent(new Event('pagehide'));
11394
});
11495

115-
// eslint-disable-next-line no-console
116-
console.log('2 - dispatched event');
117-
11896
// Get the INP span envelope
11997
const spanEnvelopes = await spanEnvelopesPromise;
12098

121-
// expect(spanEnvelopes).toBe(2);
12299
expect(spanEnvelopes).toHaveLength(1);
123100
expect(spanEnvelopes[0].op).toBe('ui.interaction.click');
124101
expect(spanEnvelopes[0].description).toBe('body > button.clicked');
125-
expect(spanEnvelopes[0].exclusive_time).toBeGreaterThan(150);
126-
expect(spanEnvelopes[0].measurements?.inp.value).toBeGreaterThan(150);
102+
expect(spanEnvelopes[0].exclusive_time).toBeGreaterThan(400);
103+
expect(spanEnvelopes[0].measurements?.inp.value).toBeGreaterThan(400);
127104
expect(spanEnvelopes[0].measurements?.inp.unit).toBe('millisecond');
128105
},
129106
);

0 commit comments

Comments
 (0)