-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
feat(features): add profiling-view flag
#3837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3837 +/- ##
=======================================
Coverage 99.45% 99.45%
=======================================
Files 3 3
Lines 183 183
=======================================
Hits 182 182
Misses 1 1 ☔ View full report in Codecov by Sentry. |
for feature in (
"organizations:discover",
"organizations:global-views",
"organizations:incidents",
"organizations:integrations-issue-basic",
"organizations:integrations-issue-sync",
"organizations:invite-members",
"organizations:sso-basic",
"organizations:sso-saml2",
"organizations:performance-view",
"organizations:advanced-search",
"organizations:session-replay",
"organizations:issue-platform",
"organizations:profiling",
"organizations:profiling-view",
"organizations:monitors",
"organizations:dashboards-mep",
"organizations:mep-rollout-flag",
"organizations:dashboards-rh-widget",
"organizations:transaction-metrics-extraction",
"organizations:visibility-explore-view",
"organizations:dynamic-sampling",
"projects:custom-inbound-filters",
"projects:data-forwarding",
"projects:discard-groups",
"projects:plugins",
"projects:rate-limits",
"projects:servicehooks",
)I feel like it's better if we tidy up these feature flags. Rather than moving on with #3802, why not just categorize the flags into something like: # Core features
for feature in (
"organizations:discover",
"organizations:global-views",
"organizations:incidents",
"organizations:integrations-issue-basic",
"organizations:integrations-issue-sync",
"organizations:invite-members",
"organizations:sso-basic",
"organizations:sso-saml2",
"organizations:advanced-search",
"organizations:issue-platform",
"organizations:dashboards-mep",
"organizations:mep-rollout-flag",
"organizations:dashboards-rh-widget",
"organizations:dynamic-sampling",
"projects:custom-inbound-filters",
"projects:data-forwarding",
"projects:discard-groups",
"projects:plugins",
"projects:rate-limits",
"projects:servicehooks",
)
# Span/transactions feature
+ (
"organizations:performance-view",
"organizations:visibility-explore-view",
"organizations:transaction-metrics-extraction",
)
# Profiling feature
+ (
"organizations:profiling",
"organizations:profiling-view",
)
# Cron monitoring feature
+ (
"organizations:monitors",
)
# Session Replays feature
+ (
"organizations:session-replay",
) |
|
@aldy505 I do like sectioning out the features into groups |
Closes getsentry/sentry#95752