Skip to content

Conversation

@aldy505
Copy link
Collaborator

@aldy505 aldy505 commented Jul 29, 2025

@aldy505 aldy505 requested a review from Zylphrex July 29, 2025 03:39
@aldy505 aldy505 enabled auto-merge (squash) July 29, 2025 03:39
@codecov
Copy link

codecov bot commented Jul 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.45%. Comparing base (524b8d4) to head (986b0c4).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3837   +/-   ##
=======================================
  Coverage   99.45%   99.45%           
=======================================
  Files           3        3           
  Lines         183      183           
=======================================
  Hits          182      182           
  Misses          1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aldy505
Copy link
Collaborator Author

aldy505 commented Jul 29, 2025

        for feature in (
            "organizations:discover",
            "organizations:global-views",
            "organizations:incidents",
            "organizations:integrations-issue-basic",
            "organizations:integrations-issue-sync",
            "organizations:invite-members",
            "organizations:sso-basic",
            "organizations:sso-saml2",
            "organizations:performance-view",
            "organizations:advanced-search",
            "organizations:session-replay",
            "organizations:issue-platform",
            "organizations:profiling",
            "organizations:profiling-view",
            "organizations:monitors",
            "organizations:dashboards-mep",
            "organizations:mep-rollout-flag",
            "organizations:dashboards-rh-widget",
            "organizations:transaction-metrics-extraction",
            "organizations:visibility-explore-view",
            "organizations:dynamic-sampling",
            "projects:custom-inbound-filters",
            "projects:data-forwarding",
            "projects:discard-groups",
            "projects:plugins",
            "projects:rate-limits",
            "projects:servicehooks",
        )

I feel like it's better if we tidy up these feature flags. Rather than moving on with #3802, why not just categorize the flags into something like:

        # Core features
        for feature in (
            "organizations:discover",
            "organizations:global-views",
            "organizations:incidents",
            "organizations:integrations-issue-basic",
            "organizations:integrations-issue-sync",
            "organizations:invite-members",
            "organizations:sso-basic",
            "organizations:sso-saml2",
            "organizations:advanced-search",
            "organizations:issue-platform",
            "organizations:dashboards-mep",
            "organizations:mep-rollout-flag",
            "organizations:dashboards-rh-widget",
            "organizations:dynamic-sampling",
            "projects:custom-inbound-filters",
            "projects:data-forwarding",
            "projects:discard-groups",
            "projects:plugins",
            "projects:rate-limits",
            "projects:servicehooks",
        ) 
        # Span/transactions feature
        + (
            "organizations:performance-view",
            "organizations:visibility-explore-view",
            "organizations:transaction-metrics-extraction",
        )
        # Profiling feature
        + (
            "organizations:profiling",
            "organizations:profiling-view",
        )
        # Cron monitoring feature
        + (
            "organizations:monitors",
        )
        # Session Replays feature
        + (
            "organizations:session-replay",
        )

@aldy505 aldy505 merged commit 84d0d23 into master Jul 29, 2025
13 checks passed
@aldy505 aldy505 deleted the aldy505/feat/profiling-view-flag branch July 29, 2025 10:17
@hubertdeng123
Copy link
Member

@aldy505 I do like sectioning out the features into groups

aldy505 added a commit that referenced this pull request Aug 1, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Aug 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Profiling setup checkbox is greyed out on configuration page on self-hosted

4 participants