Skip to content

Conversation

@rbro112
Copy link
Member

@rbro112 rbro112 commented Oct 24, 2025

Adds app icon uploading to objectstore and passes the returned objectstore id, app_icon_id. to the update API as part of preprocessing.

Likely don't want to merge this as-is as the objectstore code is just copied in, but here nonetheless in prep for merge.

Copy link
Member Author

rbro112 commented Oct 24, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codecov
Copy link

codecov bot commented Oct 24, 2025

Codecov Report

❌ Patch coverage is 47.16312% with 149 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.62%. Comparing base (de07a59) to head (265a811).
⚠️ Report is 7 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/launchpad/utils/objectstore/service.py 45.63% 56 Missing ⚠️
src/launchpad/utils/objectstore/metadata.py 39.72% 44 Missing ⚠️
src/launchpad/utils/objectstore/metrics.py 27.27% 32 Missing ⚠️
src/launchpad/artifact_processor.py 50.00% 13 Missing ⚠️
src/launchpad/utils/file_utils.py 78.94% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #430      +/-   ##
==========================================
- Coverage   80.50%   79.62%   -0.88%     
==========================================
  Files         161      162       +1     
  Lines       13383    13562     +179     
  Branches     1406     1440      +34     
==========================================
+ Hits        10774    10799      +25     
- Misses       2078     2229     +151     
- Partials      531      534       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rbro112 rbro112 marked this pull request as draft October 24, 2025 23:16
@rbro112 rbro112 force-pushed the ryan/add_icon_uploading_to_objectstore branch from 91c689a to 265a811 Compare October 30, 2025 18:22
@rbro112 rbro112 changed the title Add icon uploading to objectstore feat(preprod): Add icon uploading to objectstore Oct 30, 2025
@rbro112 rbro112 changed the title feat(preprod): Add icon uploading to objectstore Add icon uploading to objectstore Oct 30, 2025
@jan-auer
Copy link
Member

jan-auer commented Dec 5, 2025

Hi, please update objectstore_client to 0.0.14 (or any newer version available at the time)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants