-
-
Notifications
You must be signed in to change notification settings - Fork 1
Add icon uploading to objectstore #430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #430 +/- ##
==========================================
- Coverage 80.50% 79.62% -0.88%
==========================================
Files 161 162 +1
Lines 13383 13562 +179
Branches 1406 1440 +34
==========================================
+ Hits 10774 10799 +25
- Misses 2078 2229 +151
- Partials 531 534 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
91c689a to
265a811
Compare
|
Hi, please update objectstore_client to 0.0.14 (or any newer version available at the time) |

Adds app icon uploading to objectstore and passes the returned objectstore id,
app_icon_id. to the update API as part of preprocessing.Likely don't want to merge this as-is as the objectstore code is just copied in, but here nonetheless in prep for merge.