test(firestore-send-email): add edge case tests

Author: cabljac

firestore-send-email/functions/__tests__/prepare-payload.test.ts

@@ -385,7 +385,7 @@ describe("preparePayload Template Merging", () => {
   });
 
   describe("attachment validation", () => {
-    it("should handle non-array attachments", async () => {
+    it("should throw clear error for string attachments", async () => {
       const payload = {
         to: "[email protected]",
         message: {
@@ -395,7 +395,30 @@ describe("preparePayload Template Merging", () => {
         },
       };
 
-      await expect(preparePayload(payload)).rejects.toThrow();
+      await expect(preparePayload(payload)).rejects.toThrow(
+        "Invalid message configuration: Field 'message.attachments' must be an array"
+      );
+    });
+
+    it("should throw clear error for invalid attachment httpHeaders", async () => {
+      const payload = {
+        to: "[email protected]",
+        message: {
+          subject: "Test Subject",
+          text: "Test text",
+          attachments: [
+            {
+              filename: "test.txt",
+              href: "https://example.com",
+              httpHeaders: "invalid",
+            },
+          ],
+        },
+      };
+
+      await expect(preparePayload(payload)).rejects.toThrow(
+        "Invalid message configuration: Field 'message.attachments.0.httpHeaders' must be a map"
+      );
     });
 
     it("should handle null attachments as no attachments", async () => {

firestore-send-email/functions/__tests__/validation.test.ts

@@ -612,6 +612,95 @@ describe("validatePayload", () => {
         };
         expect(() => validatePayload(payload)).not.toThrow();
       });
+
+      it("should throw error for string attachments", () => {
+        const payload = {
+          to: "[email protected]",
+          message: {
+            subject: "Test Subject",
+            text: "Test message",
+            attachments: "invalid-string",
+          },
+        };
+        expect(() => validatePayload(payload)).toThrow(ValidationError);
+        expect(() => validatePayload(payload)).toThrow(
+          "Invalid message configuration: Field 'message.attachments' must be an array"
+        );
+      });
+
+      it("should throw error for number attachments", () => {
+        const payload = {
+          to: "[email protected]",
+          message: {
+            subject: "Test Subject",
+            text: "Test message",
+            attachments: 123,
+          },
+        };
+        expect(() => validatePayload(payload)).toThrow(ValidationError);
+        expect(() => validatePayload(payload)).toThrow(
+          "Invalid message configuration: Field 'message.attachments' must be an array"
+        );
+      });
+    });
+  });
+
+  describe("error messages", () => {
+    it("should provide clear error for empty template name", () => {
+      const payload = {
+        to: "[email protected]",
+        template: {
+          name: "",
+        },
+      };
+      expect(() => validatePayload(payload)).toThrow(ValidationError);
+      expect(() => validatePayload(payload)).toThrow(
+        "Invalid template configuration: Field 'template.name' cannot be empty"
+      );
+    });
+
+    it("should provide clear error for empty UID in array", () => {
+      const payload = {
+        toUids: ["valid-uid", ""],
+        message: {
+          subject: "Test",
+          text: "Test",
+        },
+      };
+      expect(() => validatePayload(payload)).toThrow(ValidationError);
+      expect(() => validatePayload(payload)).toThrow(
+        "Invalid email configuration: Field 'toUids.1' cannot be empty"
+      );
+    });
+
+    it("should provide clear error for cc as number", () => {
+      const payload = {
+        to: "[email protected]",
+        cc: 123,
+        message: {
+          subject: "Test",
+          text: "Test",
+        },
+      };
+      expect(() => validatePayload(payload)).toThrow(ValidationError);
+      expect(() => validatePayload(payload)).toThrow(
+        "Invalid email configuration: Field 'cc' must be either a string or an array of strings"
+      );
+    });
+
+    it("should provide clear error for bcc as boolean", () => {
+      const payload = {
+        to: "[email protected]",
+        bcc: true,
+        message: {
+          subject: "Test",
+          text: "Test",
+        },
+      };
+      expect(() => validatePayload(payload)).toThrow(ValidationError);
+      expect(() => validatePayload(payload)).toThrow(
+        "Invalid email configuration: Field 'bcc' must be either a string or an array of strings"
+      );
     });
   });
 });