Delete deprecated headers #538
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This diff removes the following deprecated headers: - `<unifex/execute.hpp>` (use `spawn_detached()`) - `<unifex/ready_done_sender.hpp>` (use `just_done()`) - `<unifex/submit.hpp>` (use `spawn_detached()`)` - `<unifex/via.hpp>` (use `typed_via()`) - `<unifex/via_stream.pp>` (use `typed_via_stream()`)
facebook-github-bot
added
the
CLA Signed
janondrusek
approved these changes
Jun 12, 2023
ispeters
added a commit
that referenced
this pull request
Jun 25, 2023
PR #538 deleted `unifex::via()`, which was an untyped _Sender_ algorithm, and changed all uses to use `unifex::typed_via()` instead. This diff recreates the `via.hpp` header; it now defines the "typed via" algorithm under the name `unifex::via()`. At the same time, this diff changes `unifex::typed_via` to be a deprecated alias for the `via` algorithm.
ispeters
added a commit
that referenced
this pull request
Jun 25, 2023
PR #538 deleted `unifex::via_stream()`, which was an untyped _Stream_ algorithm, and changed all uses to use `unifex::typed_via_stream()` instead. This diff recreates the `via_stream.hpp` header; it now defines the "typed via stream" algorithm under the name `unifex::via_stream()`. At the same time, this diff changes `unifex::typed_via_stream` to be a deprecated alias for the `via_stream` algorithm.
Merged
ispeters
added a commit
that referenced
this pull request
Jul 3, 2023
This builds on PRs #538 and #539 to remove the concept of "untyped" _Senders_ and thus stop calling any _Senders_ "typed" (they're all typed). - #539 made `typed_sender<S>` an alias for `sender<S>` so now I can replace all uses of `typed_sender<>` with `sender<>` and deprecate `typed_sender<>`. - In the same spirit as #539, there's no need to refer to bulk _Senders_ as "typed" so I've renamed `typed_bulk_sender<>` to `bulk_sender<>` and deprecated `typed_bulk_sender<>`. - There's no need to call it `typed_via()` so `via()` now means what `typed_via()` meant and we retain `typed_via()` as a deprecated alias for `via()`. - Similarly for `typed_via_stream()`, `via_stream()` now means what `typed_via_stream()` meant and we retain `typed_via_stream()` as a deprecated alias for `via_stream()`. - I'm also deleting three things from `sender_concepts.hpp` that have been deprecated for a long time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This diff removes the following deprecated headers:
<unifex/execute.hpp>(usespawn_detached())<unifex/ready_done_sender.hpp>(usejust_done())<unifex/submit.hpp>(usespawn_detached())`<unifex/via.hpp>(usetyped_via())<unifex/via_stream.pp>(usetyped_via_stream())