add io_uring_context::open_listening_socket
#531
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
janondrusek
force-pushed
the
accept-stream
branch
9 times, most recently
from
8bc0ccb to
d2465e9
Compare
ispeters
requested changes
May 25, 2023
Contributor
ispeters
left a comment
ispeters
left a comment
There was a problem hiding this comment.
Looks good, but I've left a whole bunch of comments.
ispeters
requested changes
May 25, 2023
Contributor
ispeters
left a comment
ispeters
left a comment
There was a problem hiding this comment.
Looks good, but I've left a whole bunch of comments.
* opens a socket on a specified port * exposes a _Stream_ of `async_read_write_file` to handle accept(s)
janondrusek
force-pushed
the
accept-stream
branch
from
d2465e9 to
ccdfe4a
Compare
ispeters
approved these changes
May 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
async_read_write_fileto handle accept(s)