Skip to content

move v1::async_scope into inline v1 namespace #511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
janondrusek merged 1 commit into from
May 3, 2023
Merged

move v1::async_scope into inline v1 namespace #511

janondrusek merged 1 commit into from
May 3, 2023

Conversation

@janondrusek
Copy link
Contributor

@janondrusek janondrusek commented May 3, 2023

  • v1::async_scope becomes unifex::async_scope
  • v0::async_scope needs to be fully qualified

@janondrusek
move v1::async_scope into inline v1 namespace
5f71479 
* `v1::async_scope` becomes `unifex::async_scope`
* `v0::async_scope` needs to be fully qualified
@janondrusek janondrusek requested a review from ispeters May 3, 2023 18:49
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 3, 2023
@janondrusek janondrusek merged commit 25f3fca into facebookexperimental:main May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ispeters ispeters ispeters approved these changes

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@janondrusek @ispeters @facebook-github-bot