Skip to content

Commit f2955db

Browse files
sebmarkbagesebmarkbage
committed
Remove useId semantics from View Transition name generation (#33094)
Originally I thought it was important that SSR used the same View Transition name as the client so that the Fizz runtime could emit those names and then the client could pick up and take over. However, I no longer believe that approach is feasible. Instead, the names can be generated only during that particular animation. Therefore we can simplify the auto name assignment to not have to consider the hydration. DiffTrain build for [845d937](845d937)
1 parent a42f581 commit f2955db

24 files changed

+314
-312
lines changed

‎compiled-rn/VERSION_NATIVE_FB‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
19.2.0-native-fb-54a50729-20250506
1+
19.2.0-native-fb-845d9374-20250506

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOM-dev.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<cf808470aadcad35d2e4bba10cadc8da>>
10+
* @generated SignedSource<<9b24d804fb0ac1652659bb2b6e421fdb>>
1111
*/
1212

1313
"use strict";
@@ -404,5 +404,5 @@ __DEV__ &&
404404
exports.useFormStatus = function () {
405405
return resolveDispatcher().useHostTransitionStatus();
406406
};
407-
exports.version = "19.2.0-native-fb-54a50729-20250506";
407+
exports.version = "19.2.0-native-fb-845d9374-20250506";
408408
})();

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOM-prod.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<85868561d5c38b5410c83a35308e2abf>>
10+
* @generated SignedSource<<fd4f96db8ff007be9751091aec8309d1>>
1111
*/
1212

1313
"use strict";
@@ -203,4 +203,4 @@ exports.useFormState = function (action, initialState, permalink) {
203203
exports.useFormStatus = function () {
204204
return ReactSharedInternals.H.useHostTransitionStatus();
205205
};
206-
exports.version = "19.2.0-native-fb-54a50729-20250506";
206+
exports.version = "19.2.0-native-fb-845d9374-20250506";

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOM-profiling.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<85868561d5c38b5410c83a35308e2abf>>
10+
* @generated SignedSource<<fd4f96db8ff007be9751091aec8309d1>>
1111
*/
1212

1313
"use strict";
@@ -203,4 +203,4 @@ exports.useFormState = function (action, initialState, permalink) {
203203
exports.useFormStatus = function () {
204204
return ReactSharedInternals.H.useHostTransitionStatus();
205205
};
206-
exports.version = "19.2.0-native-fb-54a50729-20250506";
206+
exports.version = "19.2.0-native-fb-845d9374-20250506";

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOMClient-dev.js‎

Lines changed: 42 additions & 42 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<81465f89dd5ec0a8448ab45f84059e3d>>
10+
* @generated SignedSource<<22b0fd616c9702027e7eef2abec4f914>>
1111
*/
1212

1313
/*
@@ -3760,24 +3760,6 @@ __DEV__ &&
37603760
topLevelEventsToReactNames.set(domEventName, reactName);
37613761
registerTwoPhaseEvent(reactName, [domEventName]);
37623762
}
3763-
function createCapturedValueAtFiber(value, source) {
3764-
if ("object" === typeof value && null !== value) {
3765-
var existing = CapturedStacks.get(value);
3766-
if (void 0 !== existing) return existing;
3767-
source = {
3768-
value: value,
3769-
source: source,
3770-
stack: getStackByFiberInDevAndProd(source)
3771-
};
3772-
CapturedStacks.set(value, source);
3773-
return source;
3774-
}
3775-
return {
3776-
value: value,
3777-
source: source,
3778-
stack: getStackByFiberInDevAndProd(source)
3779-
};
3780-
}
37813763
function finishQueueingConcurrentUpdates() {
37823764
for (
37833765
var endIndex = concurrentQueuesIndex,
@@ -4449,6 +4431,24 @@ __DEV__ &&
44494431
};
44504432
return mode;
44514433
}
4434+
function createCapturedValueAtFiber(value, source) {
4435+
if ("object" === typeof value && null !== value) {
4436+
var existing = CapturedStacks.get(value);
4437+
if (void 0 !== existing) return existing;
4438+
source = {
4439+
value: value,
4440+
source: source,
4441+
stack: getStackByFiberInDevAndProd(source)
4442+
};
4443+
CapturedStacks.set(value, source);
4444+
return source;
4445+
}
4446+
return {
4447+
value: value,
4448+
source: source,
4449+
stack: getStackByFiberInDevAndProd(source)
4450+
};
4451+
}
44524452
function pushTreeFork(workInProgress, totalChildren) {
44534453
warnIfNotHydrating();
44544454
forkStack[forkStackIndex++] = treeForkCount;
@@ -24263,8 +24263,22 @@ __DEV__ &&
2426324263
"abort auxClick beforeToggle cancel canPlay canPlayThrough click close contextMenu copy cut drag dragEnd dragEnter dragExit dragLeave dragOver dragStart drop durationChange emptied encrypted ended error gotPointerCapture input invalid keyDown keyPress keyUp load loadedData loadedMetadata loadStart lostPointerCapture mouseDown mouseMove mouseOut mouseOver mouseUp paste pause play playing pointerCancel pointerDown pointerMove pointerOut pointerOver pointerUp progress rateChange reset resize seeked seeking stalled submit suspend timeUpdate touchCancel touchEnd touchStart volumeChange scroll toggle touchMove waiting wheel".split(
2426424264
" "
2426524265
),
24266-
CapturedStacks = new WeakMap(),
24267-
OffscreenVisible = 1,
24266+
lastResetTime = 0;
24267+
if (
24268+
"object" === typeof performance &&
24269+
"function" === typeof performance.now
24270+
) {
24271+
var localPerformance = performance;
24272+
var getCurrentTime = function () {
24273+
return localPerformance.now();
24274+
};
24275+
} else {
24276+
var localDate = Date;
24277+
getCurrentTime = function () {
24278+
return localDate.now();
24279+
};
24280+
}
24281+
var OffscreenVisible = 1,
2426824282
OffscreenPassiveEffectsConnected = 2,
2426924283
concurrentQueues = [],
2427024284
concurrentQueuesIndex = 0,
@@ -24295,6 +24309,7 @@ __DEV__ &&
2429524309
var createFiber = enableObjectFiber
2429624310
? createFiberImplObject
2429724311
: createFiberImplClass,
24312+
CapturedStacks = new WeakMap(),
2429824313
forkStack = [],
2429924314
forkStackIndex = 0,
2430024315
treeForkProvider = null,
@@ -24314,22 +24329,7 @@ __DEV__ &&
2431424329
HydrationMismatchException = Error(
2431524330
"Hydration Mismatch Exception: This is not a real error, and should not leak into userspace. If you're seeing this, it's likely a bug in React."
2431624331
),
24317-
lastResetTime = 0;
24318-
if (
24319-
"object" === typeof performance &&
24320-
"function" === typeof performance.now
24321-
) {
24322-
var localPerformance = performance;
24323-
var getCurrentTime = function () {
24324-
return localPerformance.now();
24325-
};
24326-
} else {
24327-
var localDate = Date;
24328-
getCurrentTime = function () {
24329-
return localDate.now();
24330-
};
24331-
}
24332-
var valueCursor = createCursor(null);
24332+
valueCursor = createCursor(null);
2433324333
var rendererCursorDEV = createCursor(null);
2433424334
var rendererSigil = {};
2433524335
var currentlyRenderingFiber$1 = null,
@@ -26737,11 +26737,11 @@ __DEV__ &&
2673726737
};
2673826738
(function () {
2673926739
var isomorphicReactPackageVersion = React.version;
26740-
if ("19.2.0-native-fb-54a50729-20250506" !== isomorphicReactPackageVersion)
26740+
if ("19.2.0-native-fb-845d9374-20250506" !== isomorphicReactPackageVersion)
2674126741
throw Error(
2674226742
'Incompatible React versions: The "react" and "react-dom" packages must have the exact same version. Instead got:\n - react: ' +
2674326743
(isomorphicReactPackageVersion +
26744-
"\n - react-dom: 19.2.0-native-fb-54a50729-20250506\nLearn more: https://react.dev/warnings/version-mismatch")
26744+
"\n - react-dom: 19.2.0-native-fb-845d9374-20250506\nLearn more: https://react.dev/warnings/version-mismatch")
2674526745
);
2674626746
})();
2674726747
("function" === typeof Map &&
@@ -26778,10 +26778,10 @@ __DEV__ &&
2677826778
!(function () {
2677926779
var internals = {
2678026780
bundleType: 1,
26781-
version: "19.2.0-native-fb-54a50729-20250506",
26781+
version: "19.2.0-native-fb-845d9374-20250506",
2678226782
rendererPackageName: "react-dom",
2678326783
currentDispatcherRef: ReactSharedInternals,
26784-
reconcilerVersion: "19.2.0-native-fb-54a50729-20250506"
26784+
reconcilerVersion: "19.2.0-native-fb-845d9374-20250506"
2678526785
};
2678626786
internals.overrideHookState = overrideHookState;
2678726787
internals.overrideHookStateDeletePath = overrideHookStateDeletePath;
@@ -26925,5 +26925,5 @@ __DEV__ &&
2692526925
listenToAllSupportedEvents(container);
2692626926
return new ReactDOMHydrationRoot(initialChildren);
2692726927
};
26928-
exports.version = "19.2.0-native-fb-54a50729-20250506";
26928+
exports.version = "19.2.0-native-fb-845d9374-20250506";
2692926929
})();

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOMClient-prod.js‎

Lines changed: 25 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<db0008da807ba609b6155a66796fe2bb>>
10+
* @generated SignedSource<<03402b426a8526cbbf59afdcfc3828c6>>
1111
*/
1212

1313
/*
@@ -2347,25 +2347,6 @@ function registerSimpleEvent(domEventName, reactName) {
23472347
topLevelEventsToReactNames.set(domEventName, reactName);
23482348
registerTwoPhaseEvent(reactName, [domEventName]);
23492349
}
2350-
var CapturedStacks = new WeakMap();
2351-
function createCapturedValueAtFiber(value, source) {
2352-
if ("object" === typeof value && null !== value) {
2353-
var existing = CapturedStacks.get(value);
2354-
if (void 0 !== existing) return existing;
2355-
source = {
2356-
value: value,
2357-
source: source,
2358-
stack: getStackByFiberInDevAndProd(source)
2359-
};
2360-
CapturedStacks.set(value, source);
2361-
return source;
2362-
}
2363-
return {
2364-
value: value,
2365-
source: source,
2366-
stack: getStackByFiberInDevAndProd(source)
2367-
};
2368-
}
23692350
var concurrentQueues = [],
23702351
concurrentQueuesIndex = 0,
23712352
concurrentlyUpdatedLanes = 0;
@@ -2780,6 +2761,25 @@ function createFiberFromPortal(portal, mode, lanes) {
27802761
};
27812762
return mode;
27822763
}
2764+
var CapturedStacks = new WeakMap();
2765+
function createCapturedValueAtFiber(value, source) {
2766+
if ("object" === typeof value && null !== value) {
2767+
var existing = CapturedStacks.get(value);
2768+
if (void 0 !== existing) return existing;
2769+
source = {
2770+
value: value,
2771+
source: source,
2772+
stack: getStackByFiberInDevAndProd(source)
2773+
};
2774+
CapturedStacks.set(value, source);
2775+
return source;
2776+
}
2777+
return {
2778+
value: value,
2779+
source: source,
2780+
stack: getStackByFiberInDevAndProd(source)
2781+
};
2782+
}
27832783
var forkStack = [],
27842784
forkStackIndex = 0,
27852785
treeForkProvider = null,
@@ -16847,14 +16847,14 @@ ReactDOMHydrationRoot.prototype.unstable_scheduleHydration = function (target) {
1684716847
};
1684816848
var isomorphicReactPackageVersion$jscomp$inline_1984 = React.version;
1684916849
if (
16850-
"19.2.0-native-fb-54a50729-20250506" !==
16850+
"19.2.0-native-fb-845d9374-20250506" !==
1685116851
isomorphicReactPackageVersion$jscomp$inline_1984
1685216852
)
1685316853
throw Error(
1685416854
formatProdErrorMessage(
1685516855
527,
1685616856
isomorphicReactPackageVersion$jscomp$inline_1984,
16857-
"19.2.0-native-fb-54a50729-20250506"
16857+
"19.2.0-native-fb-845d9374-20250506"
1685816858
)
1685916859
);
1686016860
ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
@@ -16876,10 +16876,10 @@ ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
1687616876
};
1687716877
var internals$jscomp$inline_2495 = {
1687816878
bundleType: 0,
16879-
version: "19.2.0-native-fb-54a50729-20250506",
16879+
version: "19.2.0-native-fb-845d9374-20250506",
1688016880
rendererPackageName: "react-dom",
1688116881
currentDispatcherRef: ReactSharedInternals,
16882-
reconcilerVersion: "19.2.0-native-fb-54a50729-20250506"
16882+
reconcilerVersion: "19.2.0-native-fb-845d9374-20250506"
1688316883
};
1688416884
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
1688516885
var hook$jscomp$inline_2496 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
@@ -16983,4 +16983,4 @@ exports.hydrateRoot = function (container, initialChildren, options) {
1698316983
listenToAllSupportedEvents(container);
1698416984
return new ReactDOMHydrationRoot(initialChildren);
1698516985
};
16986-
exports.version = "19.2.0-native-fb-54a50729-20250506";
16986+
exports.version = "19.2.0-native-fb-845d9374-20250506";

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOMClient-profiling.js‎

Lines changed: 25 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<aeff7289453905813a14eaa5d171b725>>
10+
* @generated SignedSource<<d5a8e9edc3a9092ecff1170c469b7d3f>>
1111
*/
1212

1313
/*
@@ -2425,25 +2425,6 @@ function registerSimpleEvent(domEventName, reactName) {
24252425
topLevelEventsToReactNames.set(domEventName, reactName);
24262426
registerTwoPhaseEvent(reactName, [domEventName]);
24272427
}
2428-
var CapturedStacks = new WeakMap();
2429-
function createCapturedValueAtFiber(value, source) {
2430-
if ("object" === typeof value && null !== value) {
2431-
var existing = CapturedStacks.get(value);
2432-
if (void 0 !== existing) return existing;
2433-
source = {
2434-
value: value,
2435-
source: source,
2436-
stack: getStackByFiberInDevAndProd(source)
2437-
};
2438-
CapturedStacks.set(value, source);
2439-
return source;
2440-
}
2441-
return {
2442-
value: value,
2443-
source: source,
2444-
stack: getStackByFiberInDevAndProd(source)
2445-
};
2446-
}
24472428
var concurrentQueues = [],
24482429
concurrentQueuesIndex = 0,
24492430
concurrentlyUpdatedLanes = 0;
@@ -2874,6 +2855,25 @@ function createFiberFromPortal(portal, mode, lanes) {
28742855
};
28752856
return mode;
28762857
}
2858+
var CapturedStacks = new WeakMap();
2859+
function createCapturedValueAtFiber(value, source) {
2860+
if ("object" === typeof value && null !== value) {
2861+
var existing = CapturedStacks.get(value);
2862+
if (void 0 !== existing) return existing;
2863+
source = {
2864+
value: value,
2865+
source: source,
2866+
stack: getStackByFiberInDevAndProd(source)
2867+
};
2868+
CapturedStacks.set(value, source);
2869+
return source;
2870+
}
2871+
return {
2872+
value: value,
2873+
source: source,
2874+
stack: getStackByFiberInDevAndProd(source)
2875+
};
2876+
}
28772877
var forkStack = [],
28782878
forkStackIndex = 0,
28792879
treeForkProvider = null,
@@ -17557,14 +17557,14 @@ ReactDOMHydrationRoot.prototype.unstable_scheduleHydration = function (target) {
1755717557
};
1755817558
var isomorphicReactPackageVersion$jscomp$inline_2087 = React.version;
1755917559
if (
17560-
"19.2.0-native-fb-54a50729-20250506" !==
17560+
"19.2.0-native-fb-845d9374-20250506" !==
1756117561
isomorphicReactPackageVersion$jscomp$inline_2087
1756217562
)
1756317563
throw Error(
1756417564
formatProdErrorMessage(
1756517565
527,
1756617566
isomorphicReactPackageVersion$jscomp$inline_2087,
17567-
"19.2.0-native-fb-54a50729-20250506"
17567+
"19.2.0-native-fb-845d9374-20250506"
1756817568
)
1756917569
);
1757017570
ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
@@ -17586,10 +17586,10 @@ ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
1758617586
};
1758717587
var internals$jscomp$inline_2094 = {
1758817588
bundleType: 0,
17589-
version: "19.2.0-native-fb-54a50729-20250506",
17589+
version: "19.2.0-native-fb-845d9374-20250506",
1759017590
rendererPackageName: "react-dom",
1759117591
currentDispatcherRef: ReactSharedInternals,
17592-
reconcilerVersion: "19.2.0-native-fb-54a50729-20250506",
17592+
reconcilerVersion: "19.2.0-native-fb-845d9374-20250506",
1759317593
getLaneLabelMap: function () {
1759417594
for (
1759517595
var map = new Map(), lane = 1, index$309 = 0;
@@ -17708,4 +17708,4 @@ exports.hydrateRoot = function (container, initialChildren, options) {
1770817708
listenToAllSupportedEvents(container);
1770917709
return new ReactDOMHydrationRoot(initialChildren);
1771017710
};
17711-
exports.version = "19.2.0-native-fb-54a50729-20250506";
17711+
exports.version = "19.2.0-native-fb-845d9374-20250506";

0 commit comments

Comments
 (0)