Skip to content

Commit 0efbfeb

Browse files
sebmarkbagesebmarkbage
committed
[Fiber] Name content inside "Suspense fallback" (#33724)
Same as #33723 but for Fiber. DiffTrain build for [b44a99b](b44a99b)
1 parent a357246 commit 0efbfeb

34 files changed

+246
-166
lines changed

‎compiled/facebook-www/REVISION‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
e43986f1f3e6e94f7eef86fb21c830959e0ade6c
1+
b44a99bf58d69d52b5288d9eadcc6d226d705e11

‎compiled/facebook-www/REVISION_TRANSFORMS‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
e43986f1f3e6e94f7eef86fb21c830959e0ade6c
1+
b44a99bf58d69d52b5288d9eadcc6d226d705e11

‎compiled/facebook-www/React-dev.classic.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1434,7 +1434,7 @@ __DEV__ &&
14341434
exports.useTransition = function () {
14351435
return resolveDispatcher().useTransition();
14361436
};
1437-
exports.version = "19.2.0-www-classic-e43986f1-20250707";
1437+
exports.version = "19.2.0-www-classic-b44a99bf-20250708";
14381438
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
14391439
"function" ===
14401440
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

‎compiled/facebook-www/React-dev.modern.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1434,7 +1434,7 @@ __DEV__ &&
14341434
exports.useTransition = function () {
14351435
return resolveDispatcher().useTransition();
14361436
};
1437-
exports.version = "19.2.0-www-modern-e43986f1-20250707";
1437+
exports.version = "19.2.0-www-modern-b44a99bf-20250708";
14381438
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
14391439
"function" ===
14401440
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

‎compiled/facebook-www/React-prod.classic.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -610,4 +610,4 @@ exports.useSyncExternalStore = function (
610610
exports.useTransition = function () {
611611
return ReactSharedInternals.H.useTransition();
612612
};
613-
exports.version = "19.2.0-www-classic-e43986f1-20250707";
613+
exports.version = "19.2.0-www-classic-b44a99bf-20250708";

‎compiled/facebook-www/React-prod.modern.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -610,4 +610,4 @@ exports.useSyncExternalStore = function (
610610
exports.useTransition = function () {
611611
return ReactSharedInternals.H.useTransition();
612612
};
613-
exports.version = "19.2.0-www-modern-e43986f1-20250707";
613+
exports.version = "19.2.0-www-modern-b44a99bf-20250708";

‎compiled/facebook-www/React-profiling.classic.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -614,7 +614,7 @@ exports.useSyncExternalStore = function (
614614
exports.useTransition = function () {
615615
return ReactSharedInternals.H.useTransition();
616616
};
617-
exports.version = "19.2.0-www-classic-e43986f1-20250707";
617+
exports.version = "19.2.0-www-classic-b44a99bf-20250708";
618618
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
619619
"function" ===
620620
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

‎compiled/facebook-www/React-profiling.modern.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -614,7 +614,7 @@ exports.useSyncExternalStore = function (
614614
exports.useTransition = function () {
615615
return ReactSharedInternals.H.useTransition();
616616
};
617-
exports.version = "19.2.0-www-modern-e43986f1-20250707";
617+
exports.version = "19.2.0-www-modern-b44a99bf-20250708";
618618
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
619619
"function" ===
620620
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

‎compiled/facebook-www/ReactART-dev.classic.js‎

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -2014,7 +2014,7 @@ __DEV__ &&
20142014
"function" === typeof fn && componentFrameCache.set(fn, sampleLines);
20152015
return sampleLines;
20162016
}
2017-
function describeFiber(fiber) {
2017+
function describeFiber(fiber, childFiber) {
20182018
switch (fiber.tag) {
20192019
case 26:
20202020
case 27:
@@ -2023,7 +2023,9 @@ __DEV__ &&
20232023
case 16:
20242024
return describeBuiltInComponentFrame("Lazy");
20252025
case 13:
2026-
return describeBuiltInComponentFrame("Suspense");
2026+
return fiber.child !== childFiber && null !== childFiber
2027+
? describeBuiltInComponentFrame("Suspense Fallback")
2028+
: describeBuiltInComponentFrame("Suspense");
20272029
case 19:
20282030
return describeBuiltInComponentFrame("SuspenseList");
20292031
case 0:
@@ -2044,9 +2046,10 @@ __DEV__ &&
20442046
}
20452047
function getStackByFiberInDevAndProd(workInProgress) {
20462048
try {
2047-
var info = "";
2049+
var info = "",
2050+
previous = null;
20482051
do {
2049-
info += describeFiber(workInProgress);
2052+
info += describeFiber(workInProgress, previous);
20502053
var debugInfo = workInProgress._debugInfo;
20512054
if (debugInfo)
20522055
for (var i = debugInfo.length - 1; 0 <= i; i--) {
@@ -2074,6 +2077,7 @@ __DEV__ &&
20742077
info = JSCompiler_temp_const + JSCompiler_inline_result;
20752078
}
20762079
}
2080+
previous = workInProgress;
20772081
workInProgress = workInProgress.return;
20782082
} while (workInProgress);
20792083
return info;
@@ -19295,10 +19299,10 @@ __DEV__ &&
1929519299
(function () {
1929619300
var internals = {
1929719301
bundleType: 1,
19298-
version: "19.2.0-www-classic-e43986f1-20250707",
19302+
version: "19.2.0-www-classic-b44a99bf-20250708",
1929919303
rendererPackageName: "react-art",
1930019304
currentDispatcherRef: ReactSharedInternals,
19301-
reconcilerVersion: "19.2.0-www-classic-e43986f1-20250707"
19305+
reconcilerVersion: "19.2.0-www-classic-b44a99bf-20250708"
1930219306
};
1930319307
internals.overrideHookState = overrideHookState;
1930419308
internals.overrideHookStateDeletePath = overrideHookStateDeletePath;
@@ -19332,7 +19336,7 @@ __DEV__ &&
1933219336
exports.Shape = Shape;
1933319337
exports.Surface = Surface;
1933419338
exports.Text = Text;
19335-
exports.version = "19.2.0-www-classic-e43986f1-20250707";
19339+
exports.version = "19.2.0-www-classic-b44a99bf-20250708";
1933619340
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
1933719341
"function" ===
1933819342
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

‎compiled/facebook-www/ReactART-dev.modern.js‎

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1920,7 +1920,7 @@ __DEV__ &&
19201920
"function" === typeof fn && componentFrameCache.set(fn, sampleLines);
19211921
return sampleLines;
19221922
}
1923-
function describeFiber(fiber) {
1923+
function describeFiber(fiber, childFiber) {
19241924
switch (fiber.tag) {
19251925
case 26:
19261926
case 27:
@@ -1929,7 +1929,9 @@ __DEV__ &&
19291929
case 16:
19301930
return describeBuiltInComponentFrame("Lazy");
19311931
case 13:
1932-
return describeBuiltInComponentFrame("Suspense");
1932+
return fiber.child !== childFiber && null !== childFiber
1933+
? describeBuiltInComponentFrame("Suspense Fallback")
1934+
: describeBuiltInComponentFrame("Suspense");
19331935
case 19:
19341936
return describeBuiltInComponentFrame("SuspenseList");
19351937
case 0:
@@ -1950,9 +1952,10 @@ __DEV__ &&
19501952
}
19511953
function getStackByFiberInDevAndProd(workInProgress) {
19521954
try {
1953-
var info = "";
1955+
var info = "",
1956+
previous = null;
19541957
do {
1955-
info += describeFiber(workInProgress);
1958+
info += describeFiber(workInProgress, previous);
19561959
var debugInfo = workInProgress._debugInfo;
19571960
if (debugInfo)
19581961
for (var i = debugInfo.length - 1; 0 <= i; i--) {
@@ -1980,6 +1983,7 @@ __DEV__ &&
19801983
info = JSCompiler_temp_const + JSCompiler_inline_result;
19811984
}
19821985
}
1986+
previous = workInProgress;
19831987
workInProgress = workInProgress.return;
19841988
} while (workInProgress);
19851989
return info;
@@ -19066,10 +19070,10 @@ __DEV__ &&
1906619070
(function () {
1906719071
var internals = {
1906819072
bundleType: 1,
19069-
version: "19.2.0-www-modern-e43986f1-20250707",
19073+
version: "19.2.0-www-modern-b44a99bf-20250708",
1907019074
rendererPackageName: "react-art",
1907119075
currentDispatcherRef: ReactSharedInternals,
19072-
reconcilerVersion: "19.2.0-www-modern-e43986f1-20250707"
19076+
reconcilerVersion: "19.2.0-www-modern-b44a99bf-20250708"
1907319077
};
1907419078
internals.overrideHookState = overrideHookState;
1907519079
internals.overrideHookStateDeletePath = overrideHookStateDeletePath;
@@ -19103,7 +19107,7 @@ __DEV__ &&
1910319107
exports.Shape = Shape;
1910419108
exports.Surface = Surface;
1910519109
exports.Text = Text;
19106-
exports.version = "19.2.0-www-modern-e43986f1-20250707";
19110+
exports.version = "19.2.0-www-modern-b44a99bf-20250708";
1910719111
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
1910819112
"function" ===
1910919113
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

0 commit comments

Comments
 (0)