fix Go-to-def fails on unreachable branches #1254 #1523
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grievejia
reviewed
Nov 11, 2025
Comment on lines
+1421
to
+1710
| /// Synthesize a static definition entry for `name` in the current scope if it | ||
| /// is missing. This is used when we deliberately analyze unreachable code for | ||
| /// IDE metadata; those code paths may not have been included in the up-front | ||
| /// static scan, so we add a lightweight placeholder on demand. | ||
| pub fn add_synthetic_definition(&mut self, name: &Name, range: TextRange) { |
Contributor
There was a problem hiding this comment.
This feels a bit complicated to me. I wonder if a better alternative would be to just keep all defs in the very beginning when they are calculated, recording their unreachable status so downstream type checking logic would avoid emitting type errors for those instead.
asukaminato0721
force-pushed
the
1254
branch
from
8984cdf to
3e919fc
Compare
asukaminato0721
force-pushed
the
1254
branch
from
3e919fc to
3e93c31
Compare
|
This pull request has been automatically marked as stale because it has not had recent activity for more than 2 weeks. If you are still working on this this pull request, please add a comment or push new commits to keep it active. Otherwise, please unassign yourself and allow someone else to take over. Thank you for your contributions! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1254
Added a suppression stack so binding code can execute unreachable branches without emitting type errors and exposed a helper to gate this behavior to filesystem/memory modules only, skipping
builtins/__builtins__.Updated the if binding logic to analyze statically false branches only when the new gate allows it, then discard their flow so control-flow facts stay unchanged while IDE features (like go-to-def) gain the needed Keys.