feat: merge rule.meta.defaultOptions before validation #166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nzakas
previously approved these changes
Jul 3, 2024
Member
nzakas
left a comment
nzakas
left a comment
There was a problem hiding this comment.
Overall LGTM. Just one note about syntax.
Would like @mdjermanovic to review before merging.
nzakas
previously approved these changes
Jul 3, 2024
Member
|
@eslint/eslint-tsc This PR is still looking for another review. |
fasttime
reviewed
Jul 26, 2024
Member
fasttime
left a comment
fasttime
left a comment
There was a problem hiding this comment.
Sorry for the late review. I just left a few suggestions. Other than that, I think this looks good.
Co-authored-by: Francesco Trotta <[email protected]>
fasttime
approved these changes
Jul 26, 2024
Member
fasttime
left a comment
fasttime
left a comment
There was a problem hiding this comment.
LGTM, thanks! Pending a last review from @mdjermanovic.
1 task
Member
mdjermanovic
left a comment
mdjermanovic
left a comment
There was a problem hiding this comment.
This LGTM, but I think we should hold off merging until eslint/eslint#17656 is approved to make sure the changes are synchronized.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #165.
I felt unsure labeling this as "feat" vs. "fix" - the root behavior is, arguably, a bug fix for feature support of
rule.meta.defaultOptions... 🤷Code roughly copied from eslint/eslint#17656.