Skip to content

Commit 3669d94

Browse files
authored
mcp: update GitHub MCP after issue tool consolidation (#1436)
**Description** GitHub has consolidated the tools related to issues, causing some of our integration tests to break. This PR adjusts the tests and docs to use the new tool names. **Related Issues/PRs (if applicable)** GitHub PR: github/github-mcp-server#1211 **Special notes for reviewers (if applicable)** N/A Signed-off-by: Ignasi Barrera <[email protected]>
1 parent 2861c1b commit 3669d94

File tree

9 files changed

+16
-20
lines changed

9 files changed

+16
-20
lines changed

examples/mcp/openai-github.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -206,7 +206,7 @@ spec:
206206
path: "/mcp/x/issues/readonly"
207207
toolSelector:
208208
include:
209-
- get_issue
209+
- issue_read
210210
- list_issues
211211
securityPolicy:
212212
apiKey:

internal/autoconfig/config_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -357,7 +357,7 @@ func TestWriteConfig(t *testing.T) {
357357
BackendName: "github",
358358
Path: "/mcp/x/issues/readonly",
359359
APIKey: "${GITHUB_MCP_TOKEN}",
360-
IncludeTools: []string{"get_issue", "list_issues"},
360+
IncludeTools: []string{"issue_read", "list_issues"},
361361
},
362362
},
363363
},

internal/autoconfig/mcp_test.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ func TestAddMCPServersConfig(t *testing.T) {
2727
Headers: map[string]string{
2828
"Authorization": "Bearer ${GITHUB_MCP_TOKEN}",
2929
},
30-
IncludeTools: []string{"list_issues", "get_issue"},
30+
IncludeTools: []string{"list_issues", "issue_read"},
3131
},
3232
},
3333
},
@@ -45,7 +45,7 @@ func TestAddMCPServersConfig(t *testing.T) {
4545
{
4646
BackendName: "github",
4747
Path: "/mcp/x/issues/readonly",
48-
IncludeTools: []string{"list_issues", "get_issue"},
48+
IncludeTools: []string{"list_issues", "issue_read"},
4949
APIKey: "${GITHUB_MCP_TOKEN}",
5050
Headers: map[string]string{},
5151
},
@@ -104,7 +104,7 @@ func TestAddMCPServersConfig(t *testing.T) {
104104
Headers: map[string]string{
105105
"Authorization": "Bearer ${GITHUB_MCP_TOKEN}",
106106
},
107-
IncludeTools: []string{"list_issues", "get_issue"},
107+
IncludeTools: []string{"list_issues", "issue_read"},
108108
},
109109
},
110110
},
@@ -129,7 +129,7 @@ func TestAddMCPServersConfig(t *testing.T) {
129129
{
130130
BackendName: "github",
131131
Path: "/mcp/x/issues/readonly",
132-
IncludeTools: []string{"list_issues", "get_issue"},
132+
IncludeTools: []string{"list_issues", "issue_read"},
133133
APIKey: "${GITHUB_MCP_TOKEN}",
134134
Headers: map[string]string{},
135135
},

internal/autoconfig/testdata/openai-github.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,7 @@ spec:
125125
path: "/mcp/x/issues/readonly"
126126
toolSelector:
127127
include:
128-
- get_issue
128+
- issue_read
129129
- list_issues
130130
securityPolicy:
131131
apiKey:

site/blog/2025/2025-10-02-mcp-implementation.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@ You can also use some features, like Tool Filtering, with the existing server fi
107107
"headers": {
108108
"Authorization": "Bearer ${GITHUB_ACCESS_TOKEN}"
109109
},
110-
"tools": ["get_issue", "list_issues"]
110+
"tools": ["issue_read", "list_issues"]
111111
}
112112
}
113113
}

site/docs/capabilities/mcp/index.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ sequenceDiagram
6565

6666
- **Session Management**: The gateway creates unified sessions by encoding multiple backend session IDs, handling reconnection with `Last-Event-ID` support for SSE streams.
6767
- **Notification Handling**: Long-lived SSE streams from multiple MCP servers are merged into a single stream for clients, with proper event ID reconstruction.
68-
- **Request Routing**: Tool names are automatically prefixed with the backend name (e.g., `github__get_issue`) to route calls to the correct upstream server.
68+
- **Request Routing**: Tool names are automatically prefixed with the backend name (e.g., `github__issue_read`) to route calls to the correct upstream server.
6969

7070
For detailed architecture and design decisions, see the [MCP Gateway proposal](https://github.com/envoyproxy/ai-gateway/tree/main/docs/proposals/006-mcp-gateway).
7171

@@ -151,7 +151,7 @@ spec:
151151
path: "/mcp/x/issues/readonly"
152152
toolSelector:
153153
includeRegex:
154-
- .*_issues?.* # Matches get_issue, list_issues, etc.
154+
- .*issues?.* # Matches issue_read, list_issues, etc.
155155
securityPolicy:
156156
apiKey:
157157
secretRef:
@@ -205,7 +205,7 @@ spec:
205205

206206
Clients will see all tools with prefixed names:
207207

208-
- `github__get_issue`
208+
- `github__issue_read`
209209
- `github__list_issues`
210210
- `context7__resolve-library-id`
211211
- `context7__get-library-docs`

site/docs/cli/run.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -162,7 +162,7 @@ Use the `--mcp-config` flag to load MCP server configuration from a JSON file. T
162162
"headers": {
163163
"Authorization": "Bearer ${GITHUB_ACCESS_TOKEN}"
164164
},
165-
"includeTools": ["get_issue", "list_issues"]
165+
"includeTools": ["issue_read", "list_issues"]
166166
}
167167
}
168168
}
@@ -220,7 +220,7 @@ This follows the same convention as [Gemini CLI's tool filtering](https://google
220220
Example:
221221

222222
```json
223-
"includeTools": ["get_issue", "list_issues", "search_issues"]
223+
"includeTools": ["issue_read", "list_issues", "search_issues"]
224224
```
225225

226226
### Testing the MCP Gateway
@@ -240,7 +240,7 @@ npx @modelcontextprotocol/[email protected] \
240240
```
241241

242242
:::note
243-
Tool names are automatically prefixed with the server name (e.g., `github__get_issue`, `context7__resolve-library-id`) to route calls to the correct backend.
243+
Tool names are automatically prefixed with the server name (e.g., `github__issue_read`, `context7__resolve-library-id`) to route calls to the correct backend.
244244
:::
245245

246246
### Advanced MCP Configuration

tests/e2e-aigw/examples_mcp_test.go

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -44,12 +44,10 @@ var (
4444
filteredAllTools = []string{
4545
"context7__get-library-docs",
4646
"context7__resolve-library-id",
47-
"github__get_issue",
48-
"github__get_issue_comments",
47+
"github__issue_read",
4948
"github__list_issue_types",
5049
"github__list_issues",
5150
"github__list_pull_requests",
52-
"github__list_sub_issues",
5351
"github__pull_request_read",
5452
"github__search_issues",
5553
"github__search_pull_requests",

tests/extproc/mcp/publicmcp_test.go

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -88,13 +88,11 @@ func TestPublicMCPServers(t *testing.T) {
8888
}
8989

9090
if githubConfigured {
91-
exps = append(exps, "github__get_issue")
92-
exps = append(exps, "github__get_issue_comments")
91+
exps = append(exps, "github__issue_read")
9392
exps = append(exps, "github__pull_request_read")
9493
exps = append(exps, "github__list_issue_types")
9594
exps = append(exps, "github__list_issues")
9695
exps = append(exps, "github__list_pull_requests")
97-
exps = append(exps, "github__list_sub_issues")
9896
exps = append(exps, "github__search_issues")
9997
exps = append(exps, "github__search_pull_requests")
10098
}

0 commit comments

Comments
 (0)