feat: Use ES6 syntax (class, const/let, arrow functions) #551
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use `class` keywords for Application, Api - Use `const` or `let` for variable definitions instead of `var` - Use arrow functions instead of `function()`
Contributor
Author
|
Do anyone have an idea about my PR? |
Contributor
Author
|
Before I create this pull request, I wanted to upgrade WebDriverIO to version 6, but this repository uses old javascript. My wish is already accomplished by #631, I close this pull request. If you guys didn't need my fix, I can close this pull request earlier. I wanted your reaction. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
I try to update Spectron to WebDriverIO v5 (#349), but I realized I have to refactor it before update.
Changes
Use ES6 features: class keyword, const/let, arrow functions.
classkeywords for Application, Api, ChromeDriverconstorletfor definition variables instead ofvarfunction()addClientProperty,addClientPropertiesinapi.js(this script usesthis)selfcould be deleted