-
Notifications
You must be signed in to change notification settings - Fork 64
fix: ensure zod v3 is used to avoid issues during parameterized tool calls #248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📦 Package.json Changes DetectedThis PR modifies Checklist for Reviewers
Package.json Diffdiff --git a/package.json b/package.json
index d7701aa..47083a8 100644
--- a/package.json
+++ b/package.json
@@ -58,7 +58,7 @@
"dotenv": "^17.2.1",
"dt-app": "^0.148.1",
"open": "^8.4.2",
- "zod-to-json-schema": "^3.24.5"
+ "zod-to-json-schema": "~3.24.5"
},
"devDependencies": {
"@types/jest": "^30.0.0",
@@ -69,5 +69,8 @@
"ts-jest": "^29.4.0",
"ts-node": "^10.9.2",
"typescript": "^5.6.2"
+ },
+ "peerDependencies": {
+ "zod": "^3.23.8"
}
}
This comment was automatically generated by the PR Package.json Comment workflow. |
|
I am not 100% sure I need to restrict the allowed version range of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR addresses dependency management issues related to zod version incompatibility that could cause errors during parameterized tool calls. The changes ensure proper version constraints to prevent conflicts between the package's direct use of zod and transitive dependencies.
Key changes:
- Added
zodas a peer dependency to ensure consumers install a compatible version - Changed
zod-to-json-schemaversion specifier from caret to tilde for more controlled patch updates - Updated changelog to document the bug fix
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| package.json | Added zod peer dependency (^3.23.8) and restricted zod-to-json-schema to patch updates (~3.24.5) |
| package-lock.json | Updated lockfile to reflect the new version constraint for zod-to-json-schema |
| CHANGELOG.md | Added entry documenting the fix for parameterized tool call errors |
ff72e6a to
f61a75e
Compare
|
@christian-kreuzberger-dtx if this is fine and merged, I recommend a patch-level release |
christian-kreuzberger-dtx
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (btw, the culprit is zod-to-json-schema "allowing" zod v4, which breaks everything; this is also known to modelcontextprotocol SDK devs already, they are working on a fix: modelcontextprotocol/typescript-sdk#1040 )
This pull request addresses dependency management and bug fixes. The most important changes include the addition of a peer dependency for
zod, a bug fix for parameterized tool calls, and a minor adjustment to the version specifier forzod-to-json-schema.Dependency management:
zodas a peer dependency inpackage.jsonto ensure compatibility with consumers of the package.zod-to-json-schemafrom caret (^) to tilde (~) inpackage.jsonfor more controlled updates.Bug fix:
CHANGELOG.md.Fixes #245, #246