Reenabled .NET Core 2.1 support #1021
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmarolf
approved these changes
Mar 12, 2021
jmarolf
approved these changes
May 5, 2021
Member
Author
|
Failing integration tests are because this build cannot rollforward to preview SDKs. Unable to find a suitable commit for some repos. Removing them from the 5.x integration tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #986
In its current state dotnet-format will run on only pre-release .NET Core 2.1 and release or pre-release .NET Core 3.1 or higher. Removing the
-rc1from the runtime version will allow it to run on release versions of 2.1 again but removes the ability to run against pre-release versions.We should take this change for 5.1. Make 5.1 a LTS release that will be supported with bug fixes while .NET Core 2.1 is under support. Then, we should bump the version number to 6.0 and move the framework version to a 3.1 pre-release dropping 2.1 support from the 6.0 release.