Optimize SQL reformatting

Add a few bits of caching:

1. Add sub-function to `parse_sql` with `lru_cache`, so that repeat calls with the same query are fast.
   This saves a lot of processing in N+1 situations.
2. Cache constructed filter stacks in `get_filter_stack()`.
   This avoids recreating all the various sqlparse objects for each query.
3. Pre-compile the simplification regex.
   The `re` module already uses an internal LRU cache of regexes, but this avoids recompiling if the regex ever drops out of that cache.

Building on top of #1571, this takes run time for the same tested view from ~1100ms to ~950ms, another ~15% saving.

Author: adamchainz

debug_toolbar/panels/sql/utils.py

@@ -1,4 +1,5 @@
 import re
+from functools import lru_cache
 
 import sqlparse
 from django.utils.html import escape
@@ -32,22 +33,38 @@ def reformat_sql(sql, with_toggle=False):
 
 
 def parse_sql(sql, aligned_indent=False):
+    return _parse_sql(
+        sql,
+        dt_settings.get_config()["PRETTIFY_SQL"],
+        aligned_indent,
+    )
+
+
+@lru_cache(maxsize=128)
+def _parse_sql(sql, pretty, aligned_indent):
+    stack = get_filter_stack(pretty, aligned_indent)
+    return "".join(stack.run(sql))
+
+
+@lru_cache(maxsize=None)
+def get_filter_stack(prettify, aligned_indent):
     stack = sqlparse.engine.FilterStack()
-    if dt_settings.get_config()["PRETTIFY_SQL"]:
+    if prettify:
         stack.enable_grouping()
     if aligned_indent:
         stack.stmtprocess.append(
             sqlparse.filters.AlignedIndentFilter(char="&nbsp;", n="<br/>")
         )
     stack.preprocess.append(BoldKeywordFilter())  # add our custom filter
     stack.postprocess.append(sqlparse.filters.SerializerUnicode())  # tokens -> strings
-    return "".join(stack.run(sql))
+    return stack
+
+
+simplify_re = re.compile(r"SELECT</strong> (...........*?) <strong>FROM")
 
 
 def simplify(sql):
-    expr = r"SELECT</strong> (...........*?) <strong>FROM"
-    sub = r"SELECT</strong> &#8226;&#8226;&#8226; <strong>FROM"
-    return re.sub(expr, sub, sql)
+    return simplify_re.sub(r"SELECT</strong> &#8226;&#8226;&#8226; <strong>FROM", sql)
 
 
 def contrasting_color_generator():

docs/changes.rst

@@ -11,7 +11,7 @@ Next version
 * Reset settings when overridden in tests. Packages or projects using
   django-debug-toolbar can now use Django’s test settings tools, like
   ``@override_settings``, to reconfigure the toolbar during tests.
-* Optimize rendering of SQL panel, saving about 15% of its run time.
+* Optimize rendering of SQL panel, saving about 30% of its run time.
 
 3.2.4 (2021-12-15)
 ------------------