Use flake8-boolean-trap

Author: matthiask

debug_toolbar/panels/sql/utils.py

@@ -86,7 +86,7 @@ def process(stmt):
         return "".join(escaped_value(token) for token in stmt.flatten())
 
 
-def reformat_sql(sql, with_toggle=False):
+def reformat_sql(sql, *, with_toggle=False):
     formatted = parse_sql(sql)
     if not with_toggle:
         return formatted

debug_toolbar/panels/templates/panel.py

@@ -117,7 +117,7 @@ def _store_template_info(self, sender, **kwargs):
                                 value.model._meta.label,
                             )
                         else:
-                            token = allow_sql.set(False)
+                            token = allow_sql.set(False)  # noqa: FBT003
                             try:
                                 saferepr(value)  # this MAY trigger a db query
                             except SQLQueryTriggered:

pyproject.toml

@@ -81,7 +81,7 @@ extend-select = [
   # flake8-2020
   # "YTT",
   # flake8-boolean-trap
-  # "FBT",
+  "FBT",
   # flake8-bugbear
   "B",
   # flake8-builtins

tests/panels/test_sql.py

@@ -24,7 +24,7 @@
 from ..models import Binary, PostgresJSON
 
 
-def sql_call(use_iterator=False):
+def sql_call(*, use_iterator=False):
     qs = User.objects.all()
     if use_iterator:
         qs = qs.iterator()
@@ -105,7 +105,7 @@ async def test_cursor_wrapper_asyncio_ctx(self, mock_wrapper):
         await sync_to_async(sql_call)()
 
         async def task():
-            sql_tracking.allow_sql.set(False)
+            sql_tracking.allow_sql.set(False)  # noqa: FBT003
             # By disabling sql_tracking.allow_sql, we are indicating that any
             # future SQL queries should be stopped. If SQL query occurs,
             # it raises an exception.