fix(beefy): add fallbackPriceUsd to CLM positions (#527)

This also adds fallbackPriceUsd for CLM positions.
So Beefy CLM positions don't miss part of the value.

| Before | After |
|-|-|
|
![IMG_7091](https://github.com/user-attachments/assets/dc0e0b1c-9cd6-4897-aea7-b359c981ca7d)
|
![IMG_7092](https://github.com/user-attachments/assets/561af152-57dd-4ddc-8c2e-4c018db26e20)
|

Before the change, because we don't have a $ price for MIGGLES, the
MIGGLES-WETH position $ value was only showing the WETH part.

Author: jeanregisser

src/apps/beefy/api.ts

@@ -78,9 +78,43 @@ export async function getBeefyVaults(
   }
 }
 
-export async function getBeefyLpsPrices(): Promise<Record<string, number>> {
-  const prices = await got
-    .get(`https://api.beefy.finance/lps`)
-    .json<Record<string, number>>()
-  return prices
+export async function getBeefyPrices(
+  networkId: NetworkId,
+): Promise<Record<string, number | undefined>> {
+  const [lpsPrices, tokenPrices, tokens] = await Promise.all([
+    got
+      .get(`https://api.beefy.finance/lps`)
+      .json<Record<string, number | undefined>>(),
+    got
+      .get(`https://api.beefy.finance/prices`)
+      .json<Record<string, number | undefined>>(),
+    got
+      .get(
+        `https://api.beefy.finance/tokens/${NETWORK_ID_TO_BEEFY_BLOCKCHAIN_ID[networkId]}`,
+      )
+      .json<
+        Record<
+          string, // oracleId
+          {
+            // These are the fields we need, but there are more
+            address: string
+            oracle: string // examples: 'lps', 'tokens'
+            oracleId: string
+          }
+        >
+      >(),
+  ])
+
+  // Combine lps prices with token prices
+  return {
+    ...lpsPrices,
+    ...Object.fromEntries(
+      Object.entries(tokens)
+        .filter(([, { oracle }]) => oracle === 'tokens')
+        .map(([, { address, oracleId }]) => [
+          address.toLowerCase(),
+          tokenPrices[oracleId],
+        ]),
+    ),
+  }
 }

src/apps/beefy/positions.ts

@@ -17,12 +17,9 @@ import {
   beefyClmVaultsMulticallBytecode,
 } from './abis/beefy-clm-vaults-multicall'
 import { beefyV2AppMulticallAbi } from './abis/beefy-v2-app-multicall'
-import {
-  BaseBeefyVault,
-  GovVault,
-  getBeefyLpsPrices,
-  getBeefyVaults,
-} from './api'
+import { BaseBeefyVault, GovVault, getBeefyPrices, getBeefyVaults } from './api'
+
+type BeefyPrices = Awaited<ReturnType<typeof getBeefyPrices>>
 
 // Fetched addresses from https://github.com/beefyfinance/beefy-v2/blob/main/src/config/config.tsx
 const BEEFY_MULTICALL_ADDRESS: {
@@ -46,37 +43,40 @@ const BEEFY_MULTICALL_ADDRESS: {
 const beefyAppTokenDefinition = (
   networkId: NetworkId,
   vault: BaseBeefyVault,
-  prices: Record<string, number>,
-): AppTokenPositionDefinition => ({
-  type: 'app-token-definition',
-  networkId,
-  address: vault.earnedTokenAddress.toLowerCase(),
-  tokens: [
-    {
-      address: vault.tokenAddress.toLowerCase(),
-      networkId,
-      fallbackPriceUsd: prices[vault.id]
-        ? toSerializedDecimalNumber(prices[vault.id])
-        : undefined,
+  prices: BeefyPrices,
+): AppTokenPositionDefinition => {
+  const priceUsd = prices[vault.id]
+  return {
+    type: 'app-token-definition',
+    networkId,
+    address: vault.earnedTokenAddress.toLowerCase(),
+    tokens: [
+      {
+        address: vault.tokenAddress.toLowerCase(),
+        networkId,
+        fallbackPriceUsd: priceUsd
+          ? toSerializedDecimalNumber(priceUsd)
+          : undefined,
+      },
+    ],
+    displayProps: () => {
+      return {
+        title: vault.name + (vault.status === 'eol' ? ' (Retired)' : ''),
+        description: 'Vault',
+        imageUrl:
+          'https://raw.githubusercontent.com/valora-inc/dapp-list/main/assets/beefy.png',
+      }
     },
-  ],
-  displayProps: () => {
-    return {
-      title: vault.name + (vault.status === 'eol' ? ' (Retired)' : ''),
-      description: 'Vault',
-      imageUrl:
-        'https://raw.githubusercontent.com/valora-inc/dapp-list/main/assets/beefy.png',
-    }
-  },
-  pricePerShare: async ({ tokensByTokenId }) => {
-    const tokenId = getTokenId({
-      address: vault.tokenAddress,
-      networkId,
-    })
-    const { decimals } = tokensByTokenId[tokenId]
-    return [toDecimalNumber(BigInt(vault.pricePerFullShare), decimals)]
-  },
-})
+    pricePerShare: async ({ tokensByTokenId }) => {
+      const tokenId = getTokenId({
+        address: vault.tokenAddress,
+        networkId,
+      })
+      const { decimals } = tokensByTokenId[tokenId]
+      return [toDecimalNumber(BigInt(vault.pricePerFullShare), decimals)]
+    },
+  }
+}
 
 // CLM = Cowcentrated Liquidity Manager: https://docs.beefy.finance/beefy-products/clm
 interface ClmVaultBalanceInfo {
@@ -91,6 +91,7 @@ const beefyConcentratedContractDefinition = (
   vault: BaseBeefyVault,
   balanceInfo: ClmVaultBalanceInfo | undefined,
   description: string,
+  prices: BeefyPrices,
 ): ContractPositionDefinition | null => {
   if (!balanceInfo) {
     return null
@@ -100,10 +101,17 @@ const beefyConcentratedContractDefinition = (
     type: 'contract-position-definition',
     networkId,
     address: vault.earnedTokenAddress.toLowerCase(),
-    tokens: vault.depositTokenAddresses.map((address) => ({
-      address: address.toLowerCase(),
-      networkId,
-    })),
+    tokens: vault.depositTokenAddresses.map((address) => {
+      const addressLower = address.toLowerCase()
+      const priceUsd = prices[addressLower]
+      return {
+        address: addressLower,
+        networkId,
+        fallbackPriceUsd: priceUsd
+          ? toSerializedDecimalNumber(priceUsd)
+          : undefined,
+      }
+    }),
     displayProps: () => {
       return {
         title: vault.name + (vault.status === 'eol' ? ' (Retired)' : ''),
@@ -140,6 +148,7 @@ const beefyBaseVaultsPositions = async (
   address: Address,
   vaults: BaseBeefyVault[],
   multicallAddress: Address,
+  prices: BeefyPrices,
 ) => {
   const client = getClient(networkId)
 
@@ -171,8 +180,6 @@ const beefyBaseVaultsPositions = async (
     return []
   }
 
-  const prices = await getBeefyLpsPrices()
-
   const clmVaults = userVaults.filter((vault) => vault.type === 'cowcentrated')
   const info =
     clmVaults.length === 0
@@ -195,6 +202,7 @@ const beefyBaseVaultsPositions = async (
                 i.token1 === vault.depositTokenAddresses[1],
             ),
             'CLM Vault',
+            prices,
           )
         : beefyAppTokenDefinition(networkId, vault, prices),
     )
@@ -207,6 +215,7 @@ const beefyGovVaultsPositions = async (
   vaults: BaseBeefyVault[],
   govVaults: GovVault[],
   multicallAddress: Address,
+  prices: BeefyPrices,
 ) => {
   const client = getClient(networkId)
 
@@ -278,6 +287,7 @@ const beefyGovVaultsPositions = async (
             i.token1 === vault!.depositTokenAddresses[1],
         ),
         'CLM Pool',
+        prices,
       ),
     )
     .filter((position): position is ContractPositionDefinition => !!position)
@@ -297,20 +307,26 @@ const hook: PositionsHook = {
       return []
     }
 
-    const { vaults, govVaults } = await getBeefyVaults(networkId)
+    const [{ vaults, govVaults }, prices] = await Promise.all([
+      getBeefyVaults(networkId),
+      getBeefyPrices(networkId),
+    ])
+
     return [
       ...(await beefyBaseVaultsPositions(
         networkId,
         address as Address,
         vaults,
         multicallAddress,
+        prices,
       )),
       ...(await beefyGovVaultsPositions(
         networkId,
         address as Address,
         vaults,
         govVaults,
         multicallAddress,
+        prices,
       )),
     ]
   },