fix: added a check for restricting managers to assign superadmin through permission groups #5025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashishdevtron
requested review from
kripanshdevtron,
nishant-d and
vikramdevtron
as code owners
Shivam-nagar23
previously approved these changes
Apr 29, 2024
github-actions
bot
added
PR:Ready-to-Review
and removed
PR:Issue-verification-failed
labels
|
vikramdevtron
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
added check, no one other than super admin can assign super-admin role
Fixes #5026
Checklist:
Does this PR introduce a user-facing change?