Skip to content

Conversation

@vikramdevtron
Copy link
Contributor

Description

HPA handling for keda and fullnameOverride and nameOverride

Fixes #3445

How Has This Been Tested?

  • Deploy app with fullnameOverride and nameOverride
  • Deploy app with kedaAutoscaling

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?


@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@vikramdevtron vikramdevtron merged commit cfc412f into main Jun 16, 2023
@vikramdevtron vikramdevtron deleted the hpa-support-keda-and-name-override branch June 16, 2023 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Deployment time replicas are set wrong in case of fullnameOverride

3 participants