fix: app workflow creation api panic and app metrics update issue #3511
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kartik-579
changed the title
|
Kudos, SonarCloud Quality Gate passed!
|
vikramdevtron
approved these changes
Jun 15, 2023
gireesh-naidu
pushed a commit
that referenced
this pull request
Jun 16, 2023
* release: PR for v0.6.18-rc.1 (#3497) * Created release-notes files * Update releasenotes.md * Updated release notes * Updated latest image of devtron in installer * Updated latest image of hyperion in installer * Updated release notes * Updated latest image of hyperion in installer * Updated latest image of devtron in installer * Updated latest image of dashboard in installer * Updated release notes * Updated release notes * Updated latest image of hyperion in installer * Updated latest image of devtron in installer * Updated latest image of hyperion in installer * Updated latest image of devtron in installer * Updated release-notes files * Updated latest image of dashboard in installer * Updated release-notes files * Updated latest image of ci-runner in installer * Update Chart.yaml * Update values.yaml * Update devtron-bom.yaml * Update values.yaml * Update devtron-installer.yaml * Update installation-script * Update releasenotes.md * Updated release-notes files * Update releasenotes.md * Update releasenotes.md * Updated latest image of dashboard in installer * Updated latest image of ci-runner in installer * Update Chart.yaml * Update devtron-bom.yaml * Update values.yaml * Update devtron-installer.yaml * Update installation-script * Update releasenotes.md * Updated release-notes files --------- Co-authored-by: Pawan Mehta <[email protected]> * fix: Global secret data bug in CI workflow (#3504) * Updated latest image of hyperion in installer * Updated latest image of devtron in installer * fix Global secret data bug in CI workflow * Revert "Updated latest image of devtron in installer" This reverts commit c5f54cc. * Revert "Updated latest image of hyperion in installer" This reverts commit fb145a1. --------- Co-authored-by: ReleaseBot <[email protected]> * task: added global policy db scripts (#3486) * added db scripts * updated down script * fix: app workflow creation api panic and app metrics update issue (#3511) * fix err passing in response writer * fix for app workflow app mterics issue * removed redundant comment --------- Co-authored-by: Prakarsh <[email protected]> Co-authored-by: Pawan Mehta <[email protected]> Co-authored-by: subhashish-devtron <[email protected]> Co-authored-by: ReleaseBot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Panic handling for empty error in response writer and fixed deployment template override creation for workflow create api.
Fixes #3513
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist:
Does this PR introduce a user-facing change?