feat: Option for changing project in Helm apps and project assignment to CLI helm apps. #2780

iamayushm · 2022-12-20T10:42:13Z

Description

Option for changing project in Helm apps and option for assigning projects to unlinked CLI helm apps.

https://docs.google.com/document/d/1ME0dPLR7BSxLZQX_EQ7MFMeYSZHNvJ2uZtiE103Cvew/edit#
https://docs.google.com/document/d/1o_UHNUFHZFbCf0ELMzzv_AgA7fJm8gLiK0M76iHHN1k/edit

Fixes #2810

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration:-

EA mode

In EA mode, check whether the option for selecting a project during app deployment is available or not.
Deploy a sample app using the app store. Check that the configure tab of that app project is coming or not.
Check whether the user is able to change project of above app. Option for changing project will be there in configure tab.
Install an app using CLI.
For CLI initially Project will come as “unassigned”. Check that whether user is able to change this project.
After changing project, try linking this app to chart store and check that whether linking operation is successful or not.
Install another CLI app.
First Link this app to the Chart store and then try to assign a project. Check whether assignment operation is successful or not.

FULL mode

Repeat steps 1 to 8 for full mode.

User Permission Test (SSO will be required for testing this)

Create 2 or more projects.
Assign User to a particular project, environment and app.
Check whether apps not belonging to projects, environments and app are visible to the user or not.
If the user has manager access to a particular app, then check whether he is able to do every operation on that app, i.e update the app, view all tabs, etc.
If the user has view access then check whether he is able to view all tabs for that app but can not update that app.
If a user is changing a project for an app then make sure that he has access to both projects, current project and the updated project.

Checklist:

The title of the PR states what changed and the related issues number (used for the release note).
Does this PR requires documentation updates?
I've updated documentation as required by this PR.
I have performed a self-review of my own code.
I have commented my code, particularly in hard-to-understand areas.
I have tested it for all user roles.
I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?

# Conflicts: # cmd/external-app/router.go # cmd/external-app/wire_gen.go

…xist

gitguardian · 2022-12-20T10:42:17Z

⚠️ GitGuardian has uncovered 7 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request

GitGuardian id	Secret	Commit	Filename
141558	Generic High Entropy Secret	`42a2e9c`	scripts/devtron-reference-helm-charts/deployment-chart_1-0-0/env-values.yaml	View secret
2763127	Generic High Entropy Secret	`42a2e9c`	scripts/devtron-reference-helm-charts/deployment-chart_1-0-0/secrets-test-values.yaml	View secret
5236769	Generic High Entropy Secret	`42a2e9c`	scripts/devtron-reference-helm-charts/deployment-chart_1-0-0/test-values.json	View secret
141558	Generic High Entropy Secret	`52b4858`	scripts/devtron-reference-helm-charts/deployment-chart_1-0-0/env-values.yaml	View secret
2763127	Generic High Entropy Secret	`52b4858`	scripts/devtron-reference-helm-charts/deployment-chart_1-0-0/secrets-test-values.yaml	View secret
141558	Generic High Entropy Secret	`6c405f2`	scripts/devtron-reference-helm-charts/cronjob-chart_1-4-0/env-values.yaml	View secret
2763127	Generic High Entropy Secret	`6c405f2`	scripts/devtron-reference-helm-charts/cronjob-chart_1-4-0/secrets-test-values.yaml	View secret

🛠 Guidelines to remediate hardcoded secrets

Understand the implications of revoking this secret by investigating where it is used in your code.
Replace and store your secrets safely. Learn here the best practices.
Revoke and rotate these secrets.
If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

following these best practices for managing and storing secrets including API keys and other credentials
install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.

^{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!}

# Conflicts: # cmd/external-app/wire_gen.go # util/k8s/k8sApplicationRestHandler.go

# Conflicts: # api/router/AppListingRouter.go

api/appStore/deployment/AppStoreDeploymentRestHandler.go

pkg/app/AppCrudOperationService.go

pkg/appStore/deployment/service/AppStoreDeploymentService.go

sonarqubecloud · 2023-01-16T04:10:38Z

SonarCloud Quality Gate failed.

0 Bugs
0 Vulnerabilities
0 Security Hotspots
11 Code Smells

No Coverage information
10.5% Duplication

iamayushm added 30 commits December 5, 2022 19:48

adding Team in release info

edb8a49

wip

57df8ea

wip

3d2bd3d

shifting app by team id from pipeline build to app listing service

8dc6266

shifting app by team id from pipeline build to app listing service

ccb6b0e

shifting app by team id from app listing to app service

3d04fb5

adding app router in EA mode

a8b5103

adding app router in EA mode

a78b289

adding app router in EA mode

f456970

temp enforcing by email

df2d8cc

adding project condition

ea32057

wip

a83e329

wip - rbac object for case when env id is zero

01150e4

wip - changing rbac object an temporarily enforcing by email.

9a5cd3d

wip - changing rbac object an temporarily enforcing by email.

007ad6d

wip

8e7fe32

wip

427f16e

wip

a853fdf

wip: changing rbac for k8s resource and

91dc6d2

wip: changing rbac for app listing page

ec467df

rbac in get host urls by batch

1396152

wip

b470e7e

api for updating project in cli mode

65f9a00

wip: added app name field in update project api for helm app

85bca98

Merge branch 'main' into project_field_in_EA_mode

e7872f0

# Conflicts: # cmd/external-app/router.go # cmd/external-app/wire_gen.go

Merge branch 'main' into project_field_in_EA_mode

42a2e9c

Merge branch 'main' into project_field_cli_helm_apps

52b4858

Merge branch 'project_field_in_EA_mode' into project_field_cli_helm_apps

016fb48

wip: api for getting app meta info by app name

728355c

wip: stopping app creation during linking of cli apps if app aleady e…

f2fde45

…xist

wip: correcting rbac call for get helm app meta info

9ac0083

changing installedAppVersion id to installedAppId

9ecd861

vikramdevtron previously approved these changes Dec 22, 2022

View reviewed changes

iamayushm added 2 commits December 27, 2022 14:03

Merge branch 'main' into project_field_cli_helm_apps

6c405f2

correcting rbac call for futuristic case

200711f

iamayushm dismissed vikramdevtron’s stale review via 200711f December 27, 2022 14:08

iamayushm added 7 commits December 27, 2022 20:11

correcting rbac call for futuristic case

aa8b2e1

adding project in helm list api

fb30419

adding project in helm list api

a90dbf9

handling futuristic case in env autocomplete api

48b22e6

open api spec for update helm project api

ada3ac1

open api spec for get helm app meta info

81f065a

Merge branch 'main' into project_field_cli_helm_apps

7c479a4

# Conflicts: # cmd/external-app/wire_gen.go # util/k8s/k8sApplicationRestHandler.go

iamayushm mentioned this pull request Jan 12, 2023

feat: Project field in EA mode for app store apps #2763

Open

9 tasks

iamayushm added 3 commits January 13, 2023 00:05

changes after merge

ddfd982

Merge branch 'main' into project_field_cli_helm_apps

916a9c1

# Conflicts: # api/router/AppListingRouter.go

correcting telemetry rbac

53ff24e

vikramdevtron previously approved these changes Jan 13, 2023

View reviewed changes

correcting rbac

b828bb3

iamayushm dismissed vikramdevtron’s stale review via b828bb3 January 13, 2023 17:21

correcting openapi spec

94b5892

kartik-579 requested changes Jan 13, 2023

View reviewed changes

iamayushm added 3 commits January 14, 2023 01:49

review changes

16f7b77

renaming enforcer helm object

f7d502f

Merge branch 'main' into project_field_cli_helm_apps

4d9a720

kartik-579 approved these changes Jan 16, 2023

View reviewed changes

iamayushm merged commit 851c54b into main Jan 16, 2023

iamayushm deleted the project_field_cli_helm_apps branch January 16, 2023 04:27

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: Option for changing project in Helm apps and project assignment to CLI helm apps. #2780

feat: Option for changing project in Helm apps and project assignment to CLI helm apps. #2780

Uh oh!

iamayushm commented Dec 20, 2022 •

edited

Loading

Uh oh!

gitguardian bot commented Dec 20, 2022 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sonarqubecloud bot commented Jan 16, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

feat: Option for changing project in Helm apps and project assignment to CLI helm apps. #2780

feat: Option for changing project in Helm apps and project assignment to CLI helm apps. #2780

Uh oh!

Conversation

iamayushm commented Dec 20, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

How Has This Been Tested?

Checklist:

Does this PR introduce a user-facing change?

Uh oh!

gitguardian bot commented Dec 20, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ GitGuardian has uncovered 7 secrets following the scan of your pull request.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sonarqubecloud bot commented Jan 16, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

iamayushm commented Dec 20, 2022 •

edited

Loading

gitguardian bot commented Dec 20, 2022 •

edited

Loading