Skip to content

Commit b575960

Browse files
committed
adding deployed by field in deployment history of helm apps.
1 parent e47a769 commit b575960

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

pkg/appStore/deployment/tool/gitops/AppStoreDeploymentArgoCdService.go

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -294,7 +294,11 @@ func (impl AppStoreDeploymentArgoCdServiceImpl) GetDeploymentHistory(ctx context
294294
return result, err
295295
}
296296
for _, updateHistory := range versionHistory {
297-
user, _ := impl.userService.GetById(updateHistory.CreatedBy)
297+
user, err := impl.userService.GetById(updateHistory.CreatedBy)
298+
if err != nil {
299+
impl.Logger.Errorw("error while fetching user Details", "error", err)
300+
return result, err
301+
}
298302
history = append(history, &client.HelmAppDeploymentDetail{
299303
ChartMetadata: &client.ChartMetadata{
300304
ChartName: installedAppVersionModel.AppStoreApplicationVersion.AppStore.Name,

0 commit comments

Comments
 (0)