Skip to content

Conversation

@everpcpc
Copy link
Member

@everpcpc everpcpc commented Dec 3, 2025

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-build this PR changes build/testing/ci steps label Dec 3, 2025
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment on lines +140 to +144
- { dataset: hits, size: Small, database: clickbench, timeout: 10 }
- { dataset: hits, size: Large, database: clickbench, timeout: 10 }
- { dataset: tpch, size: Small, database: clickbench, timeout: 20 }
- { dataset: tpch, size: Large, database: clickbench, timeout: 20 }
- { dataset: tpch1000, size: Large, database: tpch_1000, timeout: 60 }

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Wire matrix timeouts into cloud benchmark job

The new matrix entries add per-dataset timeout values (lines 140‑144), but the cloud job still hardcodes timeout-minutes: 20 for the benchmark step; the matrix value is never consumed. As a result tpch1000 runs still time out after 20 minutes instead of the intended 60, so the change in this commit has no effect on the longer benchmark.

Useful? React with 👍 / 👎.

@everpcpc everpcpc merged commit 904b58f into databendlabs:main Dec 3, 2025
10 checks passed
@everpcpc everpcpc deleted the fix-ci branch December 3, 2025 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-build this PR changes build/testing/ci steps

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant