chore: eliminate several unnecessary branches from the hot path of the aggregate function #19028
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
pr-chore
forsaken628
force-pushed
the
aggr_table
branch
from
d2d062a to
598e927
Compare
Contributor
Docker Image for PR
|
Contributor
forsaken628
added
ci-benchmark
forsaken628
force-pushed
the
aggr_table
branch
from
20b6fb8 to
34dd017
Compare
Contributor
Docker Image for PR
|
forsaken628
added
ci-benchmark
Contributor
Docker Image for PR
|
Contributor
Contributor
Docker Image for PR
|
Contributor
forsaken628
force-pushed
the
aggr_table
branch
from
556f389 to
2783017
Compare
forsaken628
changed the title
forsaken628
added
ci-benchmark-cloud
Contributor
Docker Image for PR
|
Contributor
everpcpc
reviewed
Dec 1, 2025
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
sundy-li
approved these changes
Dec 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
Tests
Type of change
This change is