refactor(meta): extract utilities from monolithic util.rs #18678
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
pr-refactor
Transform the large util.rs file (561 lines) into 8 focused utility modules to improve code organization, maintainability, and developer experience. PROBLEM: - Monolithic util.rs with 561 lines and 16 scattered functions - Inconsistent import patterns across 39 API files - 165+ occurrences of duplicated transaction utilities - Poor discoverability and maintainability SOLUTION: Applied incremental refactoring with backward compatibility: EXTRACTED MODULES: - txn_condition_util.rs - Transaction condition builders (txn_cond_eq_seq, txn_cond_seq) - txn_retry_util.rs - Transaction retry patterns (txn_backoff re-export) - serialization_util.rs - Data serialization (serialize_struct, deserialize_struct, etc.) - error_util.rs - Error construction (6 functions from util.rs, database_util.rs, schema_api.rs) - kv_fetch_util.rs - KV operations (get_u64_value, fetch_id, 4 others) - txn_op_builder_util.rs - Transaction builders (txn_put_pb, txn_op_del, 3 others) - txn_core_util.rs - Core transactions (send_txn, txn_delete_exact, txn_replace_exact) - data_retention_util.rs - Retention logic (is_drop_time_retainable, get_retention_boundary)
Contributor
🤖 Smart Auto-retry Analysis
📊 Summary
❌ NO RETRY NEEDEDAll failures appear to be code/test issues requiring manual fixes. 🔍 Job Details
🤖 AboutAutomated analysis using job annotations to distinguish infrastructure issues (auto-retried) from code/test issues (manual fixes needed). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
refactor(meta): extract utilities from monolithic util.rs
Transform the large util.rs file (561 lines) into 8 focused utility modules
to improve code organization, maintainability, and developer experience.
PROBLEM:
SOLUTION:
Applied incremental refactoring with backward compatibility:
EXTRACTED MODULES:
Tests
Type of change
Related Issues
This change is