feat: add settings to control analyze table (#18642)

* add settings to control analyze table

* fix test

* fix

* fix test

* rename

* Update src/query/settings/src/settings_default.rs

* Update src/query/settings/src/settings_getter_setter.rs

* Update src/query/settings/src/settings_getter_setter.rs

---------

Co-authored-by: dantengsky <[email protected]>

Author: zhyass

src/query/service/src/interpreters/interpreter_table_analyze.rs

@@ -150,7 +150,9 @@ impl Interpreter for AnalyzeTableInterpreter {
             .get_settings()
             .get_sql_dialect()?
             .default_ident_quote();
-        if self.ctx.get_settings().get_enable_analyze_histogram()? {
+        if self.ctx.get_settings().get_enable_analyze_histogram()?
+            && self.ctx.get_settings().get_enable_table_snapshot_stats()?
+        {
             let histogram_sqls = table
                     .schema()
                     .fields()

src/query/service/src/test_kits/fixture.rs

@@ -943,7 +943,7 @@ impl TestFixture {
             self.default_table_name()
         );
         let ctx = self.new_query_ctx().await?;
-        ctx.get_settings().set_enable_analyze_histogram(1)?;
+        ctx.get_settings().set_enable_table_snapshot_stats(1)?;
         let mut planner = Planner::new(ctx.clone());
         let (plan, _) = planner.plan_sql(&query).await?;
         let executor = InterpreterFactory::get(ctx.clone(), &plan).await?;

src/query/settings/src/settings_default.rs

@@ -1016,6 +1016,13 @@ impl DefaultSettings {
                     scope: SettingScope::Both,
                     range: Some(SettingRange::Numeric(0..=1)),
                 }),
+                ("enable_table_snapshot_stats", DefaultSettingValue {
+                    value: UserSettingValue::UInt64(0),
+                    desc: "Enable analyze table statistics for snapshots",
+                    mode: SettingMode::Both,
+                    scope: SettingScope::Both,
+                    range: Some(SettingRange::Numeric(0..=1)),
+                }),
                 ("enable_experimental_row_access_policy", DefaultSettingValue {
                     value: UserSettingValue::UInt64(0),
                     desc: "experiment setting enable row access policy(disable by default).",

src/query/settings/src/settings_getter_setter.rs

@@ -641,11 +641,6 @@ impl Settings {
         Ok(self.try_get_u64("enable_analyze_histogram")? != 0)
     }
 
-    /// used for test
-    pub fn set_enable_analyze_histogram(&self, val: u64) -> Result<()> {
-        self.try_set_u64("enable_analyze_histogram", val)
-    }
-
     pub fn get_enable_aggregating_index_scan(&self) -> Result<bool> {
         Ok(self.try_get_u64("enable_aggregating_index_scan")? != 0)
     }
@@ -1073,4 +1068,12 @@ impl Settings {
     pub fn get_enable_binary_to_utf8_lossy(&self) -> Result<bool> {
         Ok(self.try_get_u64("enable_binary_to_utf8_lossy")? == 1)
     }
+
+    pub fn get_enable_table_snapshot_stats(&self) -> Result<bool> {
+        Ok(self.try_get_u64("enable_table_snapshot_stats")? != 0)
+    }
+
+    pub fn set_enable_table_snapshot_stats(&self, val: u64) -> Result<()> {
+        self.try_set_u64("enable_table_snapshot_stats", val)
+    }
 }

src/query/storages/fuse/src/operations/analyze.rs

@@ -225,20 +225,25 @@ impl SinkAnalyzeState {
             ..Default::default()
         });
 
-        let table_statistics = TableSnapshotStatistics::new(
-            self.ndv_states.clone(),
-            self.histograms.clone(),
-            self.snapshot_id,
-            snapshot.summary.row_count,
-        );
-        new_snapshot.table_statistics_location = Some(
-            table
-                .meta_location_generator
-                .snapshot_statistics_location_from_uuid(
-                    &table_statistics.snapshot_id,
-                    table_statistics.format_version(),
-                )?,
-        );
+        let table_statistics = if self.ctx.get_settings().get_enable_table_snapshot_stats()? {
+            let stats = TableSnapshotStatistics::new(
+                self.ndv_states.clone(),
+                self.histograms.clone(),
+                self.snapshot_id,
+                snapshot.summary.row_count,
+            );
+            new_snapshot.table_statistics_location = Some(
+                table
+                    .meta_location_generator
+                    .snapshot_statistics_location_from_uuid(
+                        &stats.snapshot_id,
+                        stats.format_version(),
+                    )?,
+            );
+            Some(stats)
+        } else {
+            None
+        };
 
         let (col_stats, cluster_stats) =
             self.regenerate_statistics(table, snapshot.as_ref()).await?;
@@ -251,7 +256,7 @@ impl SinkAnalyzeState {
                 &table.table_info,
                 &table.meta_location_generator,
                 new_snapshot,
-                Some(table_statistics),
+                table_statistics,
                 &None,
                 &table.operator,
             )

tests/sqllogictests/suites/base/06_show/06_0025_show_statistics.test

@@ -41,6 +41,9 @@ showstatistics t2 c1 2 2 2 0 4 (empty)
 statement ok
 set enable_analyze_histogram=1;
 
+statement ok
+set enable_table_snapshot_stats  = 1;
+
 statement ok
 analyze table showstatistics.t2;
 

tests/sqllogictests/suites/base/09_fuse_engine/09_0020_analyze.test

@@ -113,6 +113,9 @@ create or replace table t1 as select number as a from numbers(10);
 statement ok
 set enable_analyze_histogram=1;
 
+statement ok
+set enable_table_snapshot_stats  = 1;
+
 statement ok
 analyze table t1;
 

tests/sqllogictests/suites/base/09_fuse_engine/09_0044_issue_17314.test

@@ -7,6 +7,9 @@ use issue_17314
 statement ok
 set enable_analyze_histogram=1;
 
+statement ok
+set enable_table_snapshot_stats  = 1;
+
 statement ok
 create or replace table t1(a string, biz_date1 string);